third_party/WebKit/Source/core/html/HTMLFormControlElementTest.cpp - Issue 2197953002: Remove unnecessary uses of HTMLDocument

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLFormControlElementTest.cpp

Issue 2197953002: Remove unnecessary uses of HTMLDocument (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: simplify Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLDocument.cpp ('k') | third_party/WebKit/Source/core/html/HTMLObjectElement.cpp » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "core/html/HTMLFormControlElement.h"	5 #include "core/html/HTMLFormControlElement.h"

6	6

	7 #include "core/dom/Document.h"

7 #include "core/frame/FrameView.h"	8 #include "core/frame/FrameView.h"

8 #include "core/html/HTMLDocument.h"

9 #include "core/html/HTMLInputElement.h"	9 #include "core/html/HTMLInputElement.h"

10 #include "core/layout/LayoutObject.h"	10 #include "core/layout/LayoutObject.h"

11 #include "core/loader/EmptyClients.h"	11 #include "core/loader/EmptyClients.h"

12 #include "core/testing/DummyPageHolder.h"	12 #include "core/testing/DummyPageHolder.h"

13 #include "testing/gtest/include/gtest/gtest.h"	13 #include "testing/gtest/include/gtest/gtest.h"

14 #include <memory>	14 #include <memory>

15	15

16 namespace blink {	16 namespace blink {

17	17

18 class HTMLFormControlElementTest : public ::testing::Test {	18 class HTMLFormControlElementTest : public ::testing::Test {

19 protected:	19 protected:

20 void SetUp() override;	20 void SetUp() override;

21	21

22 DummyPageHolder& page() const { return *m_dummyPageHolder; }	22 DummyPageHolder& page() const { return *m_dummyPageHolder; }

23 HTMLDocument& document() const { return *m_document; }	23 Document& document() const { return *m_document; }

24	24

25 private:	25 private:

26 std::unique_ptr<DummyPageHolder> m_dummyPageHolder;	26 std::unique_ptr<DummyPageHolder> m_dummyPageHolder;

27 Persistent<HTMLDocument> m_document;	27 Persistent<Document> m_document;

28 };	28 };

29	29

30 void HTMLFormControlElementTest::SetUp()	30 void HTMLFormControlElementTest::SetUp()

31 {	31 {

32 Page::PageClients pageClients;	32 Page::PageClients pageClients;

33 fillWithEmptyClients(pageClients);	33 fillWithEmptyClients(pageClients);

34 m_dummyPageHolder = DummyPageHolder::create(IntSize(800, 600), &pageClients) ;	34 m_dummyPageHolder = DummyPageHolder::create(IntSize(800, 600), &pageClients) ;

35	35

36 m_document = toHTMLDocument(&m_dummyPageHolder->document());	36 m_document = &m_dummyPageHolder->document();

37 m_document->setMimeType("text/html");	37 m_document->setMimeType("text/html");

38 }	38 }

39	39

40 TEST_F(HTMLFormControlElementTest, customValidationMessageTextDirection)	40 TEST_F(HTMLFormControlElementTest, customValidationMessageTextDirection)

41 {	41 {

42 document().documentElement()->setInnerHTML("<body><input pattern='abc' value ='def' id=input></body>", ASSERT_NO_EXCEPTION);	42 document().documentElement()->setInnerHTML("<body><input pattern='abc' value ='def' id=input></body>", ASSERT_NO_EXCEPTION);

43 document().view()->updateAllLifecyclePhases();	43 document().view()->updateAllLifecyclePhases();

44	44

45 HTMLInputElement* input = toHTMLInputElement(document().getElementById("inpu t"));	45 HTMLInputElement* input = toHTMLInputElement(document().getElementById("inpu t"));

46 input->setCustomValidity(String::fromUTF8("\xD8\xB9\xD8\xB1\xD8\xA8\xD9\x89" ));	46 input->setCustomValidity(String::fromUTF8("\xD8\xB9\xD8\xB1\xD8\xA8\xD9\x89" ));

(...skipping 22 matching lines...) Expand all Loading...
69	69

70 input->setCustomValidity(String());	70 input->setCustomValidity(String());

71 message = input->validationMessage().stripWhiteSpace();	71 message = input->validationMessage().stripWhiteSpace();

72 subMessage = input->validationSubMessage().stripWhiteSpace();	72 subMessage = input->validationSubMessage().stripWhiteSpace();

73 input->findCustomValidationMessageTextDirection(message, messageDir, subMess age, subMessageDir);	73 input->findCustomValidationMessageTextDirection(message, messageDir, subMess age, subMessageDir);

74 EXPECT_EQ(LTR, messageDir);	74 EXPECT_EQ(LTR, messageDir);

75 EXPECT_EQ(RTL, subMessageDir);	75 EXPECT_EQ(RTL, subMessageDir);

76 }	76 }

77	77

78 } // namespace blink	78 } // namespace blink

OLD	NEW