Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 219773006: Revert of Make results_dashboard send just one request per test run. (Closed)

Created:
6 years, 8 months ago by rlarocque
Modified:
6 years, 8 months ago
CC:
chromium-reviews, kjellander-cc_chromium.org, cmp-cc_chromium.org, ilevy-cc_chromium.org, stip+watch_chromium.org, tonyg
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Visibility:
Public.

Description

Revert of Make results_dashboard send just one request per test run. (https://codereview.chromium.org/217053012/) Reason for revert: I think this change is responsible for some buildbot failures. http://build.chromium.org/p/chromium.gpu/builders/Mac%2010.8%20Release%20%28ATI%29/builds/19584 @@@STEP_TEXT@tab_capture_performance_tests@@@ @@@STEP_TEXT@<div class="BuildResultInfo">@@@ @@@STEP_TEXT@</div>@@@ @@@STEP_LOG_LINE@graphs.dat@{}@@@ @@@STEP_LOG_END_PERF@graphs.dat@tab_capture_performance@@@ Traceback (most recent call last): File "/b/build/scripts/slave/runtest.py", line 1743, in <module> sys.exit(main()) File "/b/build/scripts/slave/runtest.py", line 1707, in main result = _MainMac(options, args) File "/b/build/scripts/slave/runtest.py", line 935, in _MainMac options.factory_properties.get('perf_config')) File "/b/build/scripts/slave/runtest.py", line 604, in _SendResultsToDashboard build_dir, supplemental_columns) File "/b/build/scripts/slave/results_dashboard.py", line 59, in SendResults supplemental_columns) File "/b/build/scripts/slave/results_dashboard.py", line 192, in _GetResultsJson _PrintLinkStep(url, master, perf_id, test_name, revision) UnboundLocalError: local variable 'revision' referenced before assignment Original issue's description: > Make results_dashboard send just one request per test run. > > The PerformanceLogs() method of the log processor classes returns a dictionary mapping "log file" names to lists of lines. Each one of those log files corresponds to one chart name. > > Previously, we were invoking _SendResultsToDashboard for each "log file"; that is, each chart name. > > With this change, we are now passing the whole dict returned by PerformanceLogs() and making just one request for all points in all charts for a given test run. > > BUG= > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=260698 TBR=stip@chromium.org,qyearsley@chromium.org NOTREECHECKS=true NOTRY=true BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=260714

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+200 lines, -285 lines) Patch
M scripts/slave/results_dashboard.py View 4 chunks +85 lines, -110 lines 0 comments Download
M scripts/slave/runtest.py View 2 chunks +12 lines, -5 lines 0 comments Download
M scripts/slave/unittests/results_dashboard_test.py View 20 chunks +103 lines, -170 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rlarocque
Created Revert of Make results_dashboard send just one request per test run.
6 years, 8 months ago (2014-04-01 00:15:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlarocque@chromium.org/219773006/1
6 years, 8 months ago (2014-04-01 00:15:51 UTC) #2
commit-bot: I haz the power
6 years, 8 months ago (2014-04-01 00:17:41 UTC) #3
Message was sent while issue was closed.
Change committed as 260714

Powered by Google App Engine
This is Rietveld 408576698