Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1860)

Unified Diff: scripts/slave/runtest.py

Issue 219773006: Revert of Make results_dashboard send just one request per test run. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « scripts/slave/results_dashboard.py ('k') | scripts/slave/unittests/results_dashboard_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/runtest.py
diff --git a/scripts/slave/runtest.py b/scripts/slave/runtest.py
index 5f6e908c0c7b30b275260115a755cff25e223a99..cf3cd289cf8e1f0689242f51006bd6a1927ce652 100755
--- a/scripts/slave/runtest.py
+++ b/scripts/slave/runtest.py
@@ -574,6 +574,10 @@
supplemental_columns_file, extra_columns=None):
"""Sends results from a results tracker (aka log parser) to the dashboard.
+ TODO(qyearsley): Change this function and results_dashboard.SendResults so
+ that only one request is made per test run (instead of one per graph name).
+ Also, maybe refactor this function to take fewer arguments.
+
Args:
results_tracker: An instance of a log parser class, which has been used to
process the test output, so it contains the test results.
@@ -597,11 +601,14 @@
supplemental_columns_file)
if extra_columns:
supplemental_columns.update(extra_columns)
-
- logs_dict = results_tracker.PerformanceLogs()
- results_dashboard.SendResults(logs_dict, system, test, url, mastername,
- buildername, buildername, buildnumber,
- build_dir, supplemental_columns)
+ for logname, log in results_tracker.PerformanceLogs().iteritems():
+ lines = [str(l).rstrip() for l in log]
+ try:
+ results_dashboard.SendResults(logname, lines, system, test, url,
+ mastername, buildername, buildnumber,
+ build_dir, supplemental_columns)
+ except NotImplementedError as e:
+ print 'Did not submit to results dashboard: %s' % e
def _BuildCoverageGtestExclusions(options, args):
« no previous file with comments | « scripts/slave/results_dashboard.py ('k') | scripts/slave/unittests/results_dashboard_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698