Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(766)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2197723002: [DevTools] Always instrument async tasks in V8Debugger. (Closed)

Created:
4 years, 4 months ago by dgozman
Modified:
4 years, 4 months ago
Reviewers:
kozy
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Always instrument async tasks in V8Debugger. BUG=631162 Committed: https://crrev.com/68d0ab3a2645b9763e9aaecedf17d6416bf7fae0 Cr-Commit-Position: refs/heads/master@{#408706}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -36 lines) Patch
M third_party/WebKit/Source/core/inspector/ThreadDebugger.h View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp View 3 chunks +5 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp View 2 chunks +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dgozman
Take a look please.
4 years, 4 months ago (2016-07-29 17:42:46 UTC) #2
kozy
lgtm
4 years, 4 months ago (2016-07-29 17:44:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2197723002/1
4 years, 4 months ago (2016-07-29 17:46:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-29 19:07:05 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 19:08:32 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/68d0ab3a2645b9763e9aaecedf17d6416bf7fae0
Cr-Commit-Position: refs/heads/master@{#408706}

Powered by Google App Engine
This is Rietveld 408576698