third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp - Issue 2197723002: [DevTools] Always instrument async tasks in V8Debugger.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp

Issue 2197723002: [DevTools] Always instrument async tasks in V8Debugger. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp

index 8fa3fc850ae7eb20789f136a34bc801685d258f8..1bf552c143ab89ab69106962de2da834c345befe 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp

@@ -965,12 +965,6 @@ void V8DebuggerImpl::setAsyncCallStackDepth(V8DebuggerAgentImpl* agent, int dept

if (m_maxAsyncCallStackDepth == maxAsyncCallStackDepth)

return;

- if (maxAsyncCallStackDepth && !m_maxAsyncCallStackDepth)

- m_client->enableAsyncInstrumentation();

- else if (!maxAsyncCallStackDepth && m_maxAsyncCallStackDepth)

- m_client->disableAsyncInstrumentation();

m_maxAsyncCallStackDepth = maxAsyncCallStackDepth;

if (!maxAsyncCallStackDepth)

allAsyncTasksCanceled();

@@ -1000,10 +994,8 @@ void V8DebuggerImpl::asyncTaskCanceled(void* task)

void V8DebuggerImpl::asyncTaskStarted(void* task)

{

- // Not enabled, return.

if (!m_maxAsyncCallStackDepth)

return;

m_currentTasks.push_back(task);

AsyncTaskToStackTrace::iterator stackIt = m_asyncTaskStacks.find(task);

// Needs to support following order of events: