Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Unified Diff: third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp

Issue 2197723002: [DevTools] Always instrument async tasks in V8Debugger. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp
diff --git a/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp b/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp
index f7d6bd6bf6f5aef0681e7910d334d5c17f45b59a..2d3cf3c79961e39f37b7d279c799f4ac67ab38d6 100644
--- a/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp
+++ b/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp
@@ -30,7 +30,6 @@ namespace blink {
ThreadDebugger::ThreadDebugger(v8::Isolate* isolate)
: m_isolate(isolate)
, m_debugger(V8Debugger::create(isolate, this))
- , m_asyncInstrumentationEnabled(false)
{
}
@@ -73,32 +72,27 @@ void ThreadDebugger::idleFinished(v8::Isolate* isolate)
void ThreadDebugger::asyncTaskScheduled(const String& operationName, void* task, bool recurring)
{
- if (m_asyncInstrumentationEnabled)
- m_debugger->asyncTaskScheduled(operationName, task, recurring);
+ m_debugger->asyncTaskScheduled(operationName, task, recurring);
}
void ThreadDebugger::asyncTaskCanceled(void* task)
{
- if (m_asyncInstrumentationEnabled)
- m_debugger->asyncTaskCanceled(task);
+ m_debugger->asyncTaskCanceled(task);
}
void ThreadDebugger::allAsyncTasksCanceled()
{
- if (m_asyncInstrumentationEnabled)
- m_debugger->allAsyncTasksCanceled();
+ m_debugger->allAsyncTasksCanceled();
}
void ThreadDebugger::asyncTaskStarted(void* task)
{
- if (m_asyncInstrumentationEnabled)
- m_debugger->asyncTaskStarted(task);
+ m_debugger->asyncTaskStarted(task);
}
void ThreadDebugger::asyncTaskFinished(void* task)
{
- if (m_asyncInstrumentationEnabled)
- m_debugger->asyncTaskFinished(task);
+ m_debugger->asyncTaskFinished(task);
}
unsigned ThreadDebugger::promiseRejected(v8::Local<v8::Context> context, const String16& errorMessage, v8::Local<v8::Value> exception, std::unique_ptr<SourceLocation> location)
@@ -168,18 +162,6 @@ bool ThreadDebugger::isInspectableHeapObject(v8::Local<v8::Object> object)
return true;
}
-void ThreadDebugger::enableAsyncInstrumentation()
-{
- DCHECK(!m_asyncInstrumentationEnabled);
- m_asyncInstrumentationEnabled = true;
-}
-
-void ThreadDebugger::disableAsyncInstrumentation()
-{
- DCHECK(m_asyncInstrumentationEnabled);
- m_asyncInstrumentationEnabled = false;
-}
-
static void returnDataCallback(const v8::FunctionCallbackInfo<v8::Value>& info)
{
info.GetReturnValue().Set(info.Data());

Powered by Google App Engine
This is Rietveld 408576698