Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 2197613003: gpu: Introduce GpuChannelEstablishFactory. (Closed)

Created:
4 years, 4 months ago by sadrul
Modified:
4 years, 4 months ago
CC:
chromium-reviews, rjkroege, mlamouri+watch-content_chromium.org, sadrul, posciak+watch_chromium.org, tfarina, sievers+watch_chromium.org, jbauman+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, piman+watch_chromium.org, kalyank, danakj+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu: Introduce GpuChannelEstablishFactory. This CL introduces GpuChannelEstablishFactory, which can be used to make a connection to the GPU process. For mus, the ui::GpuService installs itself as the factory. With this approach, less code in content/ needs to know about mus. If no factory is installed, then BrowserGpuChannelHostFactory is used instead. BUG=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/3f6627d640a0badc8185c96ad19095116d1569e3 Cr-Commit-Position: refs/heads/master@{#410612}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Total comments: 1

Patch Set 7 : . #

Patch Set 8 : . #

Patch Set 9 : . #

Patch Set 10 : . #

Patch Set 11 : . #

Patch Set 12 : . #

Patch Set 13 : . #

Patch Set 14 : . #

Patch Set 15 : . #

Patch Set 16 : . #

Patch Set 17 : . #

Total comments: 2

Patch Set 18 : tot merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+205 lines, -148 lines) Patch
M chrome/browser/DEPS View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.h View 1 2 3 4 5 6 7 8 11 12 13 14 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 3 chunks +16 lines, -2 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/browser_main_loop.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 2 chunks +8 lines, -1 line 0 comments Download
M content/browser/compositor/gpu_process_transport_factory.h View 1 2 3 4 5 6 7 8 3 chunks +9 lines, -3 lines 0 comments Download
M content/browser/compositor/gpu_process_transport_factory.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 chunks +25 lines, -60 lines 0 comments Download
M content/browser/compositor/image_transport_factory.h View 1 2 3 4 5 6 7 8 2 chunks +7 lines, -0 lines 0 comments Download
M content/browser/compositor/test/no_transport_image_transport_factory.h View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/compositor/test/no_transport_image_transport_factory.cc View 1 2 3 4 5 6 7 8 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/gpu/browser_gpu_channel_host_factory.h View 1 2 3 4 5 6 7 8 3 chunks +8 lines, -6 lines 0 comments Download
M content/browser/gpu/browser_gpu_channel_host_factory.cc View 1 2 3 4 5 6 7 8 9 10 11 6 chunks +22 lines, -25 lines 0 comments Download
M content/browser/gpu/gpu_ipc_browsertests.cc View 1 2 3 4 5 6 7 8 8 chunks +52 lines, -22 lines 0 comments Download
M content/browser/renderer_host/context_provider_factory_impl_android.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/context_provider_factory_impl_android.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/media/video_capture_gpu_jpeg_decoder.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/media/video_capture_gpu_jpeg_decoder.cc View 1 2 3 4 5 6 1 chunk +2 lines, -3 lines 0 comments Download
M content/public/browser/content_browser_client.h View 1 2 3 4 5 6 7 8 2 chunks +7 lines, -0 lines 0 comments Download
M content/public/browser/content_browser_client.cc View 1 2 3 4 5 6 7 8 1 chunk +5 lines, -0 lines 0 comments Download
M gpu/ipc/client/gpu_channel_host.h View 1 2 3 4 5 6 7 8 1 chunk +13 lines, -0 lines 0 comments Download
M services/ui/common/gpu_service.h View 1 2 3 4 5 6 7 8 9 10 3 chunks +8 lines, -5 lines 0 comments Download
M services/ui/common/gpu_service.cc View 1 2 3 4 5 6 7 8 9 10 4 chunks +10 lines, -11 lines 0 comments Download
M ui/views/mus/window_manager_connection.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 94 (80 generated)
sadrul
I considered making BrowserGpuChannelHostFactory into a GpuChannelEstablishFactory too. I think that would've been nice. But ...
4 years, 4 months ago (2016-07-30 01:06:50 UTC) #24
piman
CauseForGpuLaunch doesn't fit well in gpu/ because it encodes concerns of the higher levels. That ...
4 years, 4 months ago (2016-08-02 03:14:45 UTC) #29
sadrul
I had to do some cleanups first (https://codereview.chromium.org/2194003002/, https://codereview.chromium.org/2208613002/). One more (https://codereview.chromium.org/2215353004/) remains to land, ...
4 years, 4 months ago (2016-08-05 19:54:44 UTC) #65
piman
lgtm https://codereview.chromium.org/2197613003/diff/320001/content/browser/browser_main_loop.cc File content/browser/browser_main_loop.cc (right): https://codereview.chromium.org/2197613003/diff/320001/content/browser/browser_main_loop.cc#newcode1214 content/browser/browser_main_loop.cc:1214: BrowserGpuChannelHostFactory::Initialize(established_gpu_channel); Should we avoid doing this if we ...
4 years, 4 months ago (2016-08-08 15:36:31 UTC) #70
sadrul
https://codereview.chromium.org/2197613003/diff/320001/content/browser/browser_main_loop.cc File content/browser/browser_main_loop.cc (right): https://codereview.chromium.org/2197613003/diff/320001/content/browser/browser_main_loop.cc#newcode1214 content/browser/browser_main_loop.cc:1214: BrowserGpuChannelHostFactory::Initialize(established_gpu_channel); On 2016/08/08 15:36:30, piman - slow reviews until ...
4 years, 4 months ago (2016-08-08 16:25:32 UTC) #71
sadrul
+ben@chromium.org for changes in services/ui +jam@chromium.org for changes in content/public Note that this CL depends ...
4 years, 4 months ago (2016-08-08 16:34:38 UTC) #73
piman
On Mon, Aug 8, 2016 at 9:25 AM, <sadrul@chromium.org> wrote: > > https://codereview.chromium.org/2197613003/diff/320001/ > content/browser/browser_main_loop.cc ...
4 years, 4 months ago (2016-08-08 18:08:33 UTC) #74
Ben Goodger (Google)
rs lgtm for ui service stuff
4 years, 4 months ago (2016-08-08 20:09:14 UTC) #79
jam
On 2016/08/08 16:34:38, sadrul wrote: > mailto:+ben@chromium.org for changes in services/ui > > mailto:+jam@chromium.org for ...
4 years, 4 months ago (2016-08-09 01:40:35 UTC) #80
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2197613003/320001
4 years, 4 months ago (2016-08-09 02:41:42 UTC) #82
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/233478)
4 years, 4 months ago (2016-08-09 02:47:56 UTC) #84
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2197613003/340001
4 years, 4 months ago (2016-08-09 07:08:10 UTC) #91
commit-bot: I haz the power
Committed patchset #18 (id:340001)
4 years, 4 months ago (2016-08-09 08:11:55 UTC) #92
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 08:14:24 UTC) #94
Message was sent while issue was closed.
Patchset 18 (id:??) landed as
https://crrev.com/3f6627d640a0badc8185c96ad19095116d1569e3
Cr-Commit-Position: refs/heads/master@{#410612}

Powered by Google App Engine
This is Rietveld 408576698