Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(886)

Issue 2197483004: [Extensions] rm unnecessary GetRawDataResource().as_string() to reduce string copy. (Closed)

Created:
4 years, 4 months ago by lazyboy
Modified:
4 years, 4 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] rm unnecessary GetRawDataResource().as_string() to reduce string copy. BUG=None Test=None, internal change. Committed: https://crrev.com/b8199323d1aef10634c0a09a1513a5e5e4456399 Cr-Commit-Position: refs/heads/master@{#408851}

Patch Set 1 #

Patch Set 2 : git cl format #

Total comments: 2

Patch Set 3 : Devlin@ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -14 lines) Patch
M chrome/browser/extensions/component_loader.h View 1 2 4 chunks +8 lines, -5 lines 0 comments Download
M chrome/browser/extensions/component_loader.cc View 1 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_icon_source.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
lazyboy
4 years, 4 months ago (2016-07-30 00:55:08 UTC) #2
Devlin
lgtm https://codereview.chromium.org/2197483004/diff/20001/chrome/browser/extensions/component_loader.h File chrome/browser/extensions/component_loader.h (right): https://codereview.chromium.org/2197483004/diff/20001/chrome/browser/extensions/component_loader.h#newcode131 chrome/browser/extensions/component_loader.h:131: // Parses the given JSON manifest. Returns NULL ...
4 years, 4 months ago (2016-07-30 01:00:23 UTC) #3
lazyboy
https://codereview.chromium.org/2197483004/diff/20001/chrome/browser/extensions/component_loader.h File chrome/browser/extensions/component_loader.h (right): https://codereview.chromium.org/2197483004/diff/20001/chrome/browser/extensions/component_loader.h#newcode131 chrome/browser/extensions/component_loader.h:131: // Parses the given JSON manifest. Returns NULL if ...
4 years, 4 months ago (2016-07-30 01:45:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2197483004/40001
4 years, 4 months ago (2016-07-30 02:52:38 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-07-30 02:55:43 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-07-30 02:57:40 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b8199323d1aef10634c0a09a1513a5e5e4456399
Cr-Commit-Position: refs/heads/master@{#408851}

Powered by Google App Engine
This is Rietveld 408576698