[Extensions] rm unnecessary GetRawDataResource().as_string() to reduce string copy.

chrome/browser/extensions/component_loader.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_COMPONENT_LOADER_H_
 #define CHROME_BROWSER_EXTENSIONS_COMPONENT_LOADER_H_
 
 #include <stddef.h>
 
 #include <memory>
 #include <string>
 #include <vector>
 
 #include "base/callback_forward.h"
 #include "base/files/file_path.h"
+#include "base/gtest_prod_util.h"
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/weak_ptr.h"
 #include "base/values.h"
 #include "build/build_config.h"
 
 class ExtensionServiceInterface;
 class PrefService;
 class Profile;
 
@@ skipping 58 matching lines @@
 
   // Adds the default component extensions. If |skip_session_components|
   // the loader will skip loading component extensions that weren't supposed to
   // be loaded unless we are in signed user session (ChromeOS). For all other
   // platforms this |skip_session_components| is expected to be unset.
   void AddDefaultComponentExtensions(bool skip_session_components);
 
   // Similar to above but adds the default component extensions for kiosk mode.
   void AddDefaultComponentExtensionsForKioskMode(bool skip_session_components);
 
-  // Parse the given JSON manifest. Returns NULL if it cannot be parsed, or if
-  // if the result is not a DictionaryValue.
-  base::DictionaryValue* ParseManifest(
-      const std::string& manifest_contents) const;
-
   // Clear the list of registered extensions.
   void ClearAllRegistered();
 
   // Reloads a registered component extension.
   void Reload(const std::string& extension_id);
 
 #if defined(OS_CHROMEOS)
   // Calls |done_cb|, if not a null callback, on success.
   // NOTE: |done_cb| is not called if the component loader is shut down
   // during loading.
   void AddChromeVoxExtension(const base::Closure& done_cb);
   void AddChromeOsSpeechSynthesisExtension();
 #endif
 
   void set_ignore_whitelist_for_testing(bool value) {
     ignore_whitelist_for_testing_ = value;
   }
 
  private:
+  FRIEND_TEST_ALL_PREFIXES(ComponentLoaderTest, ParseManifest);
+
   // Information about a registered component extension.
   struct ComponentExtensionInfo {
     ComponentExtensionInfo(const base::DictionaryValue* manifest,
                            const base::FilePath& root_directory);
 
     // The parsed contents of the extensions's manifest file.
     const base::DictionaryValue* manifest;
 
     // Directory where the extension is stored.
     base::FilePath root_directory;
 
     // The component extension's ID.
     std::string extension_id;
   };
 
+  // Parses the given JSON manifest. Returns NULL if it cannot be parsed, or if

[Devlin, 2016/07/30 01:00:23]

s/NULL/null (or nullptr, if you prefer)

nitty nit: remove the comma after "parsed".

[lazyboy, 2016/07/30 01:45:35]

Done.

+  // if the result is not a DictionaryValue.
+  base::DictionaryValue* ParseManifest(
+      base::StringPiece manifest_contents) const;
+
   std::string Add(const std::string& manifest_contents,
                   const base::FilePath& root_directory,
                   bool skip_whitelist);
   std::string Add(const base::DictionaryValue* parsed_manifest,
                   const base::FilePath& root_directory,
                   bool skip_whitelist);
 
   // Loads a registered component extension.
   void Load(const ComponentExtensionInfo& info);
 
@@ skipping 62 matching lines @@
   base::WeakPtrFactory<ComponentLoader> weak_factory_;
 
   friend class TtsApiTest;
 
   DISALLOW_COPY_AND_ASSIGN(ComponentLoader);
 };
 
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_COMPONENT_LOADER_H_