Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2504)

Unified Diff: chrome/browser/ui/webui/extensions/extension_icon_source.cc

Issue 2197483004: [Extensions] rm unnecessary GetRawDataResource().as_string() to reduce string copy. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Devlin@ Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/component_loader.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/extensions/extension_icon_source.cc
diff --git a/chrome/browser/ui/webui/extensions/extension_icon_source.cc b/chrome/browser/ui/webui/extensions/extension_icon_source.cc
index 2230e3c478be626bc7da6da9e1787ea323cbcd69..ac6c03f417469500b92a3192620c980b26120b1c 100644
--- a/chrome/browser/ui/webui/extensions/extension_icon_source.cc
+++ b/chrome/browser/ui/webui/extensions/extension_icon_source.cc
@@ -97,9 +97,9 @@ GURL ExtensionIconSource::GetIconURL(const Extension* extension,
// static
SkBitmap* ExtensionIconSource::LoadImageByResourceId(int resource_id) {
- std::string contents = ResourceBundle::GetSharedInstance()
- .GetRawDataResourceForScale(resource_id,
- ui::SCALE_FACTOR_100P).as_string();
+ base::StringPiece contents =
+ ResourceBundle::GetSharedInstance().GetRawDataResourceForScale(
+ resource_id, ui::SCALE_FACTOR_100P);
// Convert and return it.
const unsigned char* data =
« no previous file with comments | « chrome/browser/extensions/component_loader.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698