Move the Mac Task Manager to the new backend code.

Move the Mac Task Manager to the new backend code.

BUG=528486, 528492
TEST=the new TaskManagerMacTest and existing ones

Committed: https://crrev.com/71aebed28b464536d3f285dc7ac3a60b2b7ff35b
Cr-Commit-Position: refs/heads/master@{#409340}

[Avi (use Gerrit), 2016-07-29 19:43:13]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-29 19:43:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Avi (use Gerrit), 2016-07-29 19:43:43]

Description was changed from

==========
Move the Mac Task Manager to the new backend code.

BUG=528486,528492
TEST=existing, new ones
==========

to

==========
Move the Mac Task Manager to the new backend code.

BUG=528486,528492,632775
TEST=existing, new ones
==========

[commit-bot: I haz the power, 2016-07-29 20:40:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-29 20:40:40]

Dry run: This issue passed the CQ dry run.

[Avi (use Gerrit), 2016-08-01 19:12:13]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-01 19:12:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-01 19:15:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-01 19:15:58]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Avi (use Gerrit), 2016-08-02 00:50:05]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 00:50:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 03:17:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-02 03:17:11]

Dry run: This issue passed the CQ dry run.

[Avi (use Gerrit), 2016-08-02 03:54:31]

avi@chromium.org changed reviewers:
+ afakhry@chromium.org, mark@chromium.org, nick@chromium.org

[Avi (use Gerrit), 2016-08-02 03:54:32]

Mark: all the Mac stuff
Nick/Ahmed: all the task manager stuff

[Avi (use Gerrit), 2016-08-02 03:55:20]

avi@chromium.org changed reviewers:
+ sky@chromium.org

[Avi (use Gerrit), 2016-08-02 03:55:21]

Scott, can you look at the random non-TM and non-Mac files? Specifically, build
files and Views changes.

[Avi (use Gerrit), 2016-08-02 03:55:38]

Description was changed from

==========
Move the Mac Task Manager to the new backend code.

BUG=528486,528492,632775
TEST=existing, new ones
==========

to

==========
Move the Mac Task Manager to the new backend code.

BUG=528486,528492
TEST=existing, new ones
==========

[Avi (use Gerrit), 2016-08-02 03:57:15]

Description was changed from

==========
Move the Mac Task Manager to the new backend code.

BUG=528486,528492
TEST=existing, new ones
==========

to

==========
Move the Mac Task Manager to the new backend code.

BUG=528486,528492
TEST=the new TaskManagerMacTest and existing ones
==========

[afakhry, 2016-08-02 16:41:33]

There's nothing making me happier today than seeing all of these deleted files!
:)

LGTM! Thanks!

https://codereview.chromium.org/2197483003/diff/40001/chrome/browser/task_man...
File chrome/browser/task_management/task_manager_tester.h (right):

https://codereview.chromium.org/2197483003/diff/40001/chrome/browser/task_man...
chrome/browser/task_management/task_manager_tester.h:19: class TaskManagerTester
{
Maybe this adapter isn't needed anymore, but that's certainly for a later CL.

https://codereview.chromium.org/2197483003/diff/40001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/task_manager_mac.mm (right):

https://codereview.chromium.org/2197483003/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/task_manager_mac.mm:145: if (addedRowIndex + removedRows
<= selectedItem) {
Nit: remove braces?

https://codereview.chromium.org/2197483003/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/task_manager_mac.mm:622:
DCHECK_EQ(chrome::NOTIFICATION_APP_TERMINATING, type);
I thought you hated notifications! :)

https://codereview.chromium.org/2197483003/diff/40001/chrome/browser/ui/task_...
File chrome/browser/ui/task_manager/task_manager_columns.cc (right):

https://codereview.chromium.org/2197483003/diff/40001/chrome/browser/ui/task_...
chrome/browser/ui/task_manager/task_manager_columns.cc:101: #define
COLUMNS_LIST(def) \
Thank you! :)

[Avi (use Gerrit), 2016-08-02 17:39:45]

https://codereview.chromium.org/2197483003/diff/40001/chrome/browser/task_man...
File chrome/browser/task_management/task_manager_tester.h (right):

https://codereview.chromium.org/2197483003/diff/40001/chrome/browser/task_man...
chrome/browser/task_management/task_manager_tester.h:19: class TaskManagerTester
{
On 2016/08/02 16:41:33, afakhry wrote:
> Maybe this adapter isn't needed anymore, but that's certainly for a later CL.

Acknowledged.

https://codereview.chromium.org/2197483003/diff/40001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/task_manager_mac.mm (right):

https://codereview.chromium.org/2197483003/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/task_manager_mac.mm:145: if (addedRowIndex + removedRows
<= selectedItem) {
On 2016/08/02 16:41:33, afakhry wrote:
> Nit: remove braces?

Maybe? If Mark wants me to I will, but this is a bunch of nested ifs, and I
think the braces help keep things clear.

https://codereview.chromium.org/2197483003/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/task_manager_mac.mm:622:
DCHECK_EQ(chrome::NOTIFICATION_APP_TERMINATING, type);
On 2016/08/02 16:41:33, afakhry wrote:
> I thought you hated notifications! :)

😢 You don't even know how much it hurts to have to add this.

https://codereview.chromium.org/2197483003/diff/40001/chrome/browser/ui/task_...
File chrome/browser/ui/task_manager/task_manager_columns.cc (right):

https://codereview.chromium.org/2197483003/diff/40001/chrome/browser/ui/task_...
chrome/browser/ui/task_manager/task_manager_columns.cc:101: #define
COLUMNS_LIST(def) \
On 2016/08/02 16:41:33, afakhry wrote:
> Thank you! :)

Acknowledged.

[ncarter (slow), 2016-08-02 19:49:37]

lgtm

https://codereview.chromium.org/2197483003/diff/40001/chrome/browser/task_man...
File chrome/browser/task_management/task_manager_tester.h (right):

https://codereview.chromium.org/2197483003/diff/40001/chrome/browser/task_man...
chrome/browser/task_management/task_manager_tester.h:19: class TaskManagerTester
{
On 2016/08/02 16:41:33, afakhry wrote:
> Maybe this adapter isn't needed anymore, but that's certainly for a later CL.

I think it's fine to leave this mostly intact. We need some friend code to do
the model-getting and to interpose on the table model observer, and we need
GetColumnValue so that WaitForTaskManagerStatToExceed works properly. So we need
some test code here.

The main thing we could do would be to make this class nonvirtual, and merge
TaskManagerTester and TaskManagerTesterImpl. I'd approve that CL, but I'm not
sure it actually improves the code other than reducing the line count slightly.

https://codereview.chromium.org/2197483003/diff/40001/chrome/browser/task_man...
File chrome/browser/task_manager/task_manager_util_unittest.cc (left):

https://codereview.chromium.org/2197483003/diff/40001/chrome/browser/task_man...
chrome/browser/task_manager/task_manager_util_unittest.cc:43: }
This test is potentially preservable. GetMessagePrefixID became
RendererTask::PrefixRendererTitle.

But, meh. I think we have sufficient coverage for this via browsertests, and
this is one of those tests that's essentially a reimplementation of the code
under test. So I'm okay dropping it.

https://codereview.chromium.org/2197483003/diff/40001/chrome/browser/task_man...
File chrome/browser/task_manager/web_contents_information.cc (left):

https://codereview.chromium.org/2197483003/diff/40001/chrome/browser/task_man...
chrome/browser/task_manager/web_contents_information.cc:25:
content::NOTIFICATION_WEB_CONTENTS_CONNECTED,
Nice.

This puts us down to only one usage of this infernal notification.

https://codereview.chromium.org/2197483003/diff/40001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/task_manager_mac.h (right):

https://codereview.chromium.org/2197483003/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/task_manager_mac.h:39:
task_management::TaskManagerTableModel* tableModel_;  // weak_
weak_ ?

https://codereview.chromium.org/2197483003/diff/40001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/task_manager_mac.mm (right):

https://codereview.chromium.org/2197483003/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/task_manager_mac.mm:114:
modelToViewMap_[viewToModelMap_[i]] = i;
Apparently this is what std::iota is for.

https://codereview.chromium.org/2197483003/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/task_manager_mac.mm:132: if (addedRows != 0) {
I'm pretty sure you can simplify this whole block (lines 132-153) to something
like this:

for (int& selectedItem : modelSelection) {
  if (selectedItem >= addedRowIndex) {
    selectedItem += addedRows;
    if (selectedItem < addedRowIndex) {
      // The selection was in the range of deleted rows, so clear it.
      selectedItem = -1;
    }
  }
}

https://codereview.chromium.org/2197483003/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/task_manager_mac.mm:484: if
(withinSortDescriptorsDidChange_)
Is recursion here unavoidable, or could we wire things up differently to avoid
it?

[ncarter (slow), 2016-08-02 20:01:06]

https://codereview.chromium.org/2197483003/diff/40001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/task_manager_mac.mm (right):

https://codereview.chromium.org/2197483003/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/task_manager_mac.mm:114:
modelToViewMap_[viewToModelMap_[i]] = i;
On 2016/08/02 19:49:36, ncarter wrote:
> Apparently this is what std::iota is for.

Erm, I meant the one on line 81, is std::iota-able. But tbh I don't get
std::iota, it seems so heavyweight for what it replaces, it just doesn't seem
all that useful.

[Avi (use Gerrit), 2016-08-02 20:06:57]

https://codereview.chromium.org/2197483003/diff/40001/chrome/browser/task_man...
File chrome/browser/task_management/task_manager_tester.h (right):

https://codereview.chromium.org/2197483003/diff/40001/chrome/browser/task_man...
chrome/browser/task_management/task_manager_tester.h:19: class TaskManagerTester
{
On 2016/08/02 19:49:36, ncarter wrote:
> On 2016/08/02 16:41:33, afakhry wrote:
> > Maybe this adapter isn't needed anymore, but that's certainly for a later
CL.
> 
> I think it's fine to leave this mostly intact. We need some friend code to do
> the model-getting and to interpose on the table model observer, and we need
> GetColumnValue so that WaitForTaskManagerStatToExceed works properly. So we
need
> some test code here.
> 
> The main thing we could do would be to make this class nonvirtual, and merge
> TaskManagerTester and TaskManagerTesterImpl. I'd approve that CL, but I'm not
> sure it actually improves the code other than reducing the line count
slightly.

For followup, if nothing else. This CL is big enough.

https://codereview.chromium.org/2197483003/diff/40001/chrome/browser/task_man...
File chrome/browser/task_manager/task_manager_util_unittest.cc (left):

https://codereview.chromium.org/2197483003/diff/40001/chrome/browser/task_man...
chrome/browser/task_manager/task_manager_util_unittest.cc:43: }
On 2016/08/02 19:49:36, ncarter wrote:
> This test is potentially preservable. GetMessagePrefixID became
> RendererTask::PrefixRendererTitle.
> 
> But, meh. I think we have sufficient coverage for this via browsertests, and
> this is one of those tests that's essentially a reimplementation of the code
> under test. So I'm okay dropping it.

Acknowledged.

https://codereview.chromium.org/2197483003/diff/40001/chrome/browser/task_man...
File chrome/browser/task_manager/web_contents_information.cc (left):

https://codereview.chromium.org/2197483003/diff/40001/chrome/browser/task_man...
chrome/browser/task_manager/web_contents_information.cc:25:
content::NOTIFICATION_WEB_CONTENTS_CONNECTED,
On 2016/08/02 19:49:36, ncarter wrote:
> Nice.
> 
> This puts us down to only one usage of this infernal notification.

Acknowledged.

https://codereview.chromium.org/2197483003/diff/40001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/task_manager_mac.h (right):

https://codereview.chromium.org/2197483003/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/task_manager_mac.h:39:
task_management::TaskManagerTableModel* tableModel_;  // weak_
On 2016/08/02 19:49:36, ncarter wrote:
> weak_ ?

Oh. Typo.

https://codereview.chromium.org/2197483003/diff/40001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/task_manager_mac.mm (right):

https://codereview.chromium.org/2197483003/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/task_manager_mac.mm:114:
modelToViewMap_[viewToModelMap_[i]] = i;
On 2016/08/02 19:49:36, ncarter wrote:
> Apparently this is what std::iota is for.

You mean line 80.

The problem is that _no_one_ knows what that function call does, and so it's
clearer in the code to just use a for loop.

https://codereview.chromium.org/2197483003/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/task_manager_mac.mm:132: if (addedRows != 0) {
On 2016/08/02 19:49:36, ncarter wrote:
> I'm pretty sure you can simplify this whole block (lines 132-153) to something
> like this:
> 
> for (int& selectedItem : modelSelection) {
>   if (selectedItem >= addedRowIndex) {
>     selectedItem += addedRows;
>     if (selectedItem < addedRowIndex) {
>       // The selection was in the range of deleted rows, so clear it.
>       selectedItem = -1;
>     }
>   }
> }

Here's where I have a problem. The code that I wrote, I wrote it in a way that
it was stupidly simple and easy to convince myself that it was correct.

While your code is probably right, I'm still trying to work out the edge cases.
Can I stay with the unoptimized code?

https://codereview.chromium.org/2197483003/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/task_manager_mac.mm:484: if
(withinSortDescriptorsDidChange_)
On 2016/08/02 19:49:36, ncarter wrote:
> Is recursion here unavoidable, or could we wire things up differently to avoid
> it?

This is a callback from the NSTableView class that happens any time
-[NSTableView setSortDescriptors:] is called. This is the simplest way I can
figure out to implement three-way sorting. The next simple way would be to
override an internal method that triggers a sort, but we already override too
many private APIs.

[Avi (use Gerrit), 2016-08-02 20:08:34]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 20:09:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ncarter (slow), 2016-08-02 20:16:11]

https://codereview.chromium.org/2197483003/diff/40001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/task_manager_mac.mm (right):

https://codereview.chromium.org/2197483003/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/task_manager_mac.mm:132: if (addedRows != 0) {
On 2016/08/02 20:06:56, Avi wrote:
> On 2016/08/02 19:49:36, ncarter wrote:
> > I'm pretty sure you can simplify this whole block (lines 132-153) to
something
> > like this:
> > 
> > for (int& selectedItem : modelSelection) {
> >   if (selectedItem >= addedRowIndex) {
> >     selectedItem += addedRows;
> >     if (selectedItem < addedRowIndex) {
> >       // The selection was in the range of deleted rows, so clear it.
> >       selectedItem = -1;
> >     }
> >   }
> > }
> 
> Here's where I have a problem. The code that I wrote, I wrote it in a way that
> it was stupidly simple and easy to convince myself that it was correct.
> 
> While your code is probably right, I'm still trying to work out the edge
cases.
> Can I stay with the unoptimized code?

Sure. I think this is one of those things where the act of writing it makes it
clear. But do take the one note below.

https://codereview.chromium.org/2197483003/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/task_manager_mac.mm:141: if (addedRowIndex >
selectedItem) {
Maybe at least hoist the "// Nothing to do" case out to a continue, before the
(addedRows > 0) test?

It seems inconsistent to use if (addedRowIndex <= selectedItem) on line 135, and
(addedRowIndex > selectedItem) ... else on line 141, when they're equivalent
tests.

[Avi (use Gerrit), 2016-08-02 20:31:24]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[Avi (use Gerrit), 2016-08-02 20:31:31]

https://codereview.chromium.org/2197483003/diff/40001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/task_manager_mac.mm (right):

https://codereview.chromium.org/2197483003/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/task_manager_mac.mm:141: if (addedRowIndex >
selectedItem) {
On 2016/08/02 20:16:10, ncarter wrote:
> Maybe at least hoist the "// Nothing to do" case out to a continue, before the
> (addedRows > 0) test?
> 
> It seems inconsistent to use if (addedRowIndex <= selectedItem) on line 135,
and
> (addedRowIndex > selectedItem) ... else on line 141, when they're equivalent
> tests.

Done.

[commit-bot: I haz the power, 2016-08-02 20:32:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2016-08-02 20:41:06]

Said files LGTM

[ncarter (slow), 2016-08-02 20:45:05]

lgtm

[Mark Mentovai, 2016-08-02 20:45:49]

LGTM

https://codereview.chromium.org/2197483003/diff/80001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/task_manager_mac.mm (right):

https://codereview.chromium.org/2197483003/diff/80001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/task_manager_mac.mm:601: delete this;
So can the destructor be private?

https://codereview.chromium.org/2197483003/diff/80001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/task_manager_mac.mm:628: instance_ = new
TaskManagerMac();
Likewise for the constructor.

https://codereview.chromium.org/2197483003/diff/80001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/task_manager_mac_browsertest.mm (right):

https://codereview.chromium.org/2197483003/diff/80001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/task_manager_mac_browsertest.mm:43: void
SetUpOnMainThread() override {
Make sure that GetTaskManagerMac() is false when starting out?

[Avi (use Gerrit), 2016-08-02 20:52:51]

https://codereview.chromium.org/2197483003/diff/80001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/task_manager_mac.mm (right):

https://codereview.chromium.org/2197483003/diff/80001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/task_manager_mac.mm:601: delete this;
On 2016/08/02 20:45:49, Mark Mentovai wrote:
> So can the destructor be private?

Yes.

https://codereview.chromium.org/2197483003/diff/80001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/task_manager_mac.mm:628: instance_ = new
TaskManagerMac();
On 2016/08/02 20:45:49, Mark Mentovai wrote:
> Likewise for the constructor.

Done.

https://codereview.chromium.org/2197483003/diff/80001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/task_manager_mac_browsertest.mm (right):

https://codereview.chromium.org/2197483003/diff/80001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/task_manager_mac_browsertest.mm:43: void
SetUpOnMainThread() override {
On 2016/08/02 20:45:49, Mark Mentovai wrote:
> Make sure that GetTaskManagerMac() is false when starting out?

Done.

[Avi (use Gerrit), 2016-08-02 20:54:04]

The CQ bit was checked by avi@chromium.org

[Avi (use Gerrit), 2016-08-02 20:54:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
afakhry@chromium.org, mark@chromium.org, nick@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2197483003/#ps100001
(title: "mark")

[commit-bot: I haz the power, 2016-08-02 20:54:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mark Mentovai, 2016-08-02 20:54:58]

LGTM. Thanks for this gigantic minus! Hot.

[commit-bot: I haz the power, 2016-08-02 21:58:35]

Description was changed from

==========
Move the Mac Task Manager to the new backend code.

BUG=528486,528492
TEST=the new TaskManagerMacTest and existing ones
==========

to

==========
Move the Mac Task Manager to the new backend code.

BUG=528486,528492
TEST=the new TaskManagerMacTest and existing ones
==========

[commit-bot: I haz the power, 2016-08-02 21:58:36]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-08-02 22:01:42]

Description was changed from

==========
Move the Mac Task Manager to the new backend code.

BUG=528486,528492
TEST=the new TaskManagerMacTest and existing ones
==========

to

==========
Move the Mac Task Manager to the new backend code.

BUG=528486,528492
TEST=the new TaskManagerMacTest and existing ones

Committed: https://crrev.com/71aebed28b464536d3f285dc7ac3a60b2b7ff35b
Cr-Commit-Position: refs/heads/master@{#409340}
==========

[commit-bot: I haz the power, 2016-08-02 22:01:44]

Patchset 6 (id:??) landed as
https://crrev.com/71aebed28b464536d3f285dc7ac3a60b2b7ff35b
Cr-Commit-Position: refs/heads/master@{#409340}