Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5455)

Unified Diff: chrome/browser/ui/views/new_task_manager_view_browsertest.cc

Issue 2197483003: Move the Mac Task Manager to the new backend code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: mark Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/new_task_manager_view.h ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/new_task_manager_view_browsertest.cc
diff --git a/chrome/browser/ui/views/new_task_manager_view_browsertest.cc b/chrome/browser/ui/views/new_task_manager_view_browsertest.cc
index d5b56b0e4d75f9fd7dec221abf0fdabe174e5c0d..950ef46e99c5ad94a08f0376ce856444dfc56640 100644
--- a/chrome/browser/ui/views/new_task_manager_view_browsertest.cc
+++ b/chrome/browser/ui/views/new_task_manager_view_browsertest.cc
@@ -226,6 +226,8 @@ IN_PROC_BROWSER_TEST_F(NewTaskManagerViewTest, InitialSelection) {
}
IN_PROC_BROWSER_TEST_F(NewTaskManagerViewTest, SelectionConsistency) {
+ ASSERT_NO_FATAL_FAILURE(ClearStoredColumnSettings());
+
chrome::ShowTaskManager(browser());
// Set up a total of three tabs in different processes.
@@ -262,6 +264,7 @@ IN_PROC_BROWSER_TEST_F(NewTaskManagerViewTest, SelectionConsistency) {
// Select the middle row, and store its tab id.
GetTable()->Select(FindRowForTab(tabs[1]));
EXPECT_EQ(GetTable()->FirstSelectedRow(), FindRowForTab(tabs[1]));
+ EXPECT_EQ(1, GetTable()->SelectedRowCount());
// Add 3 rows above the selection. The selected tab should not change.
for (int i = 0; i < 3; ++i) {
@@ -270,6 +273,7 @@ IN_PROC_BROWSER_TEST_F(NewTaskManagerViewTest, SelectionConsistency) {
}
ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows((rows += 3), pattern));
EXPECT_EQ(GetTable()->FirstSelectedRow(), FindRowForTab(tabs[1]));
+ EXPECT_EQ(1, GetTable()->SelectedRowCount());
// Add 2 rows below the selection. The selected tab should not change.
for (int i = 0; i < 2; ++i) {
@@ -278,6 +282,7 @@ IN_PROC_BROWSER_TEST_F(NewTaskManagerViewTest, SelectionConsistency) {
}
ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows((rows += 2), pattern));
EXPECT_EQ(GetTable()->FirstSelectedRow(), FindRowForTab(tabs[1]));
+ EXPECT_EQ(1, GetTable()->SelectedRowCount());
// Add a new row in the same process as the selection. The selected tab should
// not change.
« no previous file with comments | « chrome/browser/ui/views/new_task_manager_view.h ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698