Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Unified Diff: chrome/browser/task_manager/legacy_task_manager_tester.cc

Issue 2197483003: Move the Mac Task Manager to the new backend code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: mark Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/task_manager/guest_information.cc ('k') | chrome/browser/task_manager/panel_information.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/task_manager/legacy_task_manager_tester.cc
diff --git a/chrome/browser/task_manager/legacy_task_manager_tester.cc b/chrome/browser/task_manager/legacy_task_manager_tester.cc
deleted file mode 100644
index 77e5e46c7c3bc0088aad7f850222ad385bbc0524..0000000000000000000000000000000000000000
--- a/chrome/browser/task_manager/legacy_task_manager_tester.cc
+++ /dev/null
@@ -1,115 +0,0 @@
-// Copyright 2016 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "chrome/browser/task_management/task_manager_tester.h"
-
-#include "base/memory/ptr_util.h"
-#include "chrome/browser/sessions/session_tab_helper.h"
-#include "chrome/browser/task_management/task_manager_interface.h"
-#include "chrome/browser/task_manager/resource_provider.h"
-#include "chrome/browser/task_manager/task_manager.h"
-#include "chrome/browser/ui/browser_dialogs.h"
-#include "chrome/grit/generated_resources.h"
-#include "extensions/strings/grit/extensions_strings.h"
-
-namespace {
-
-class LegacyTaskManagerTester : public task_management::TaskManagerTester,
- public TaskManagerModelObserver {
- public:
- explicit LegacyTaskManagerTester(const base::Closure& on_resource_change)
- : on_resource_change_(on_resource_change),
- model_(TaskManager::GetInstance()->model()) {
- if (!on_resource_change_.is_null())
- model_->AddObserver(this);
- }
- ~LegacyTaskManagerTester() override {
- if (!on_resource_change_.is_null())
- model_->RemoveObserver(this);
- }
-
- // TaskManagerTester:
- int GetRowCount() override { return model_->ResourceCount(); }
-
- base::string16 GetRowTitle(int row) override {
- return model_->GetResourceTitle(row);
- }
-
- int64_t GetColumnValue(ColumnSpecifier column, int row) override {
- size_t value = 0;
- bool success = false;
- switch (column) {
- case ColumnSpecifier::COLUMN_NONE:
- break;
- case ColumnSpecifier::V8_MEMORY:
- success = model_->GetV8Memory(row, &value);
- break;
- case ColumnSpecifier::V8_MEMORY_USED:
- success = model_->GetV8MemoryUsed(row, &value);
- break;
- case ColumnSpecifier::SQLITE_MEMORY_USED:
- success = model_->GetSqliteMemoryUsedBytes(row, &value);
- break;
- }
- if (!success)
- return 0;
- return static_cast<int64_t>(value);
- }
-
- void ToggleColumnVisibility(ColumnSpecifier column) override {
- // Doing nothing is okay here; the legacy TaskManager always collects all
- // stats.
- }
-
- int32_t GetTabId(int row) override {
- if (model_->GetResourceWebContents(row)) {
- return SessionTabHelper::IdForTab(model_->GetResourceWebContents(row));
- }
- return -1;
- }
-
- void Kill(int row) override { TaskManager::GetInstance()->KillProcess(row); }
-
- void GetRowsGroupRange(int row, int* out_start, int* out_length) override {
- TaskManagerModel::GroupRange group_range =
- model_->GetGroupRangeForResource(row);
- *out_start = group_range.first;
- *out_length = group_range.second;
- }
-
- // TaskManagerModelObserver:
- void OnModelChanged() override { OnResourceChange(); }
- void OnItemsChanged(int start, int length) override { OnResourceChange(); }
- void OnItemsAdded(int start, int length) override { OnResourceChange(); }
- void OnItemsRemoved(int start, int length) override { OnResourceChange(); }
-
- private:
- void OnResourceChange() {
- if (!on_resource_change_.is_null())
- on_resource_change_.Run();
- }
- base::Closure on_resource_change_;
- TaskManagerModel* model_;
-};
-
-} // namespace
-
-namespace task_management {
-
-// static
-std::unique_ptr<TaskManagerTester> TaskManagerTester::Create(
- const base::Closure& callback) {
- if (TaskManagerInterface::IsNewTaskManagerEnabled())
- return TaskManagerTester::CreateDefault(callback);
- return base::WrapUnique(new LegacyTaskManagerTester(callback));
-}
-
-void TaskManagerTester::MaybeRefreshLegacyInstance() {
- // On Mac, the old task manager might still be used if we are not using mac
- // views. Refresh() isn't ever needed on the new task manager.
- if (!TaskManagerInterface::IsNewTaskManagerEnabled())
- TaskManager::GetInstance()->model()->Refresh();
-}
-
-} // namespace task_management
« no previous file with comments | « chrome/browser/task_manager/guest_information.cc ('k') | chrome/browser/task_manager/panel_information.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698