cc: Never make a DirectRenderer in LayerTreeHostImpl.

cc: Never make a DirectRenderer in LayerTreeHostImpl.

This DCHECKs that the OutputSurface says delegated_rendering. And fixes
a few unit test stragglers that were passing a non-delegated flag. And
then we delete code to create GLRenderer and SoftwareRenderer from
LayerTreeHostImpl.

R=enne
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/c070bf556fae8811df77edbd2a7b3a3594de660e
Cr-Commit-Position: refs/heads/master@{#411167}

[danakj, 2016-07-30 02:38:18]

Description was changed from

==========
cc: Never make a DirectRenderer in LayerTreeHostImpl.

This DCHECKs that the OutputSurface says delegated_rendering. And fixes
a few unit test stragglers that were passing a non-delegated flag. And
then we delete code to create GLRenderer and SoftwareRenderer from
LayerTreeHostImpl.

R=enne
BUG=606056
==========

to

==========
cc: Never make a DirectRenderer in LayerTreeHostImpl.

This DCHECKs that the OutputSurface says delegated_rendering. And fixes
a few unit test stragglers that were passing a non-delegated flag. And
then we delete code to create GLRenderer and SoftwareRenderer from
LayerTreeHostImpl.

R=enne
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[danakj, 2016-07-30 02:38:22]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-30 02:38:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2016-07-30 02:42:47]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-30 02:43:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-30 03:35:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-30 03:35:57]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[danakj, 2016-07-30 04:06:17]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-30 04:06:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-30 05:43:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-30 05:43:53]

Dry run: This issue passed the CQ dry run.

[danakj, 2016-08-10 18:41:39]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 18:42:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2016-08-10 18:54:56]

danakj@chromium.org changed reviewers:
+ pdr@chromium.org

[danakj, 2016-08-10 18:54:57]

+pdr for WebKit.

[enne (OOO), 2016-08-10 18:56:29]

enne@chromium.org changed reviewers:
- pdr@chromium.org

[enne (OOO), 2016-08-10 18:56:29]

lgtm

[danakj, 2016-08-10 18:59:41]

The CQ bit was unchecked by danakj@chromium.org

[pdr., 2016-08-10 19:28:40]

On 2016/08/10 at 18:56:29, enne wrote:
> lgtm

lgtm

[danakj, 2016-08-10 20:04:43]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2016-08-10 20:05:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 22:42:22]

Committed patchset #4 (id:50001)

[commit-bot: I haz the power, 2016-08-10 22:45:51]

Description was changed from

==========
cc: Never make a DirectRenderer in LayerTreeHostImpl.

This DCHECKs that the OutputSurface says delegated_rendering. And fixes
a few unit test stragglers that were passing a non-delegated flag. And
then we delete code to create GLRenderer and SoftwareRenderer from
LayerTreeHostImpl.

R=enne
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc: Never make a DirectRenderer in LayerTreeHostImpl.

This DCHECKs that the OutputSurface says delegated_rendering. And fixes
a few unit test stragglers that were passing a non-delegated flag. And
then we delete code to create GLRenderer and SoftwareRenderer from
LayerTreeHostImpl.

R=enne
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/c070bf556fae8811df77edbd2a7b3a3594de660e
Cr-Commit-Position: refs/heads/master@{#411167}
==========

[commit-bot: I haz the power, 2016-08-10 22:45:52]

Patchset 4 (id:??) landed as
https://crrev.com/c070bf556fae8811df77edbd2a7b3a3594de660e
Cr-Commit-Position: refs/heads/master@{#411167}

[Khushal, 2016-08-11 19:07:34]

khushalsagar@chromium.org changed reviewers:
+ khushalsagar@chromium.org

[Khushal, 2016-08-11 19:07:35]

+wez, dtrainor

The Blimp app still uses direct rendering for the compositor. Even after
integrating with Clank, where that will change to delegated rendering, this will
require moving the standalone app to using a display compositor first.

[danakj, 2016-08-11 22:13:46]

On Thu, Aug 11, 2016 at 12:07 PM, <khushalsagar@chromium.org> wrote:

> +wez, dtrainor
>
> The Blimp app still uses direct rendering for the compositor. Even after
> integrating with Clank, where that will change to delegated rendering,
> this will
> require moving the standalone app to using a display compositor first.
>

Blimp should absolutely be using a Display. This is going to block a
truckload of changes I'm trying to do in cc. :/
https://bugs.chromium.org/p/chromium/issues/detail?id=606056 for
https://bugs.chromium.org/p/chromium/issues/detail?id=487471


>
> https://codereview.chromium.org/2196023002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.