Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 2034583002: Initialize the Display's renderer when the Display is initialized. (Closed)

Created:
4 years, 6 months ago by danakj
Modified:
4 years, 4 months ago
Reviewers:
jbauman
CC:
chromium-reviews, cc-bugs_chromium.org, enne (OOO), piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@displaytest
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Initialize the Display's renderer when the Display is initialized. Instead of doing so lazily during the first draw. This is some cleanup followup work for https://codereview.chromium.org/2036563002/ R=jbauman BUG=487471 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/29029b805002aa295d0cc6df05d2c0b8bcc10d8e Cr-Commit-Position: refs/heads/master@{#411212}

Patch Set 1 #

Patch Set 2 : displayinit: . #

Patch Set 3 : displayinit: . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -127 lines) Patch
M cc/output/delegating_renderer.h View 1 2 2 chunks +4 lines, -10 lines 0 comments Download
M cc/output/delegating_renderer.cc View 1 2 1 chunk +0 lines, -9 lines 0 comments Download
M cc/output/gl_renderer.h View 1 2 2 chunks +6 lines, -15 lines 0 comments Download
M cc/output/gl_renderer.cc View 1 2 1 chunk +0 lines, -12 lines 0 comments Download
M cc/output/renderer_unittest.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M cc/output/software_renderer.h View 1 3 chunks +5 lines, -12 lines 0 comments Download
M cc/output/software_renderer.cc View 1 1 chunk +0 lines, -9 lines 0 comments Download
M cc/output/software_renderer_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/output/vulkan_renderer.h View 1 2 chunks +6 lines, -15 lines 0 comments Download
M cc/output/vulkan_renderer.cc View 1 1 chunk +0 lines, -12 lines 0 comments Download
M cc/surfaces/display.cc View 1 4 chunks +8 lines, -20 lines 0 comments Download
M cc/test/pixel_test.h View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/test/pixel_test.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 33 (22 generated)
danakj
4 years, 6 months ago (2016-06-02 02:01:00 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2034583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2034583002/1
4 years, 6 months ago (2016-06-02 02:02:45 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/86687) chromeos_daisy_chromium_compile_only_ng on ...
4 years, 6 months ago (2016-06-02 02:16:21 UTC) #6
jbauman
lgtm (modulo getting it to compile).
4 years, 6 months ago (2016-06-02 19:14:33 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2034583002/1
4 years, 6 months ago (2016-06-21 01:20:34 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/23738) ios-device-gn on ...
4 years, 6 months ago (2016-06-21 01:22:34 UTC) #11
danakj
ok I did this again on TOTish yay
4 years, 4 months ago (2016-08-10 19:42:50 UTC) #12
jbauman
On 2016/08/10 19:42:50, danakj wrote: > ok I did this again on TOTish yay ok, ...
4 years, 4 months ago (2016-08-10 22:26:22 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2034583002/40001
4 years, 4 months ago (2016-08-10 22:48:16 UTC) #29
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-11 01:04:37 UTC) #31
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 01:06:27 UTC) #33
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/29029b805002aa295d0cc6df05d2c0b8bcc10d8e
Cr-Commit-Position: refs/heads/master@{#411212}

Powered by Google App Engine
This is Rietveld 408576698