[DevTools] Add awaitPromise flag to Runtime.evaluate

[DevTools] Add awaitPromise flag to Runtime.evaluate

BUG=632875
R=dgozman@chromium.org

Committed: https://crrev.com/a95aa0811a396f1e1cd0869161be1ad34b477b56
Cr-Commit-Position: refs/heads/master@{#408873}

[kozy, 2016-07-30 01:08:39]

Please take a look!

I will add this flag to callFunctionOn after adding ExceptionDetails to return
value of it.

[dgozman, 2016-07-30 01:42:55]

https://codereview.chromium.org/2196003002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp
(right):

https://codereview.chromium.org/2196003002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp:253:
scope.injectedScript()->wrapEvaluateResult(errorString,
Check the errorString after this call.

https://codereview.chromium.org/2196003002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp:263: if
(!awaitPromise.fromMaybe(false) || wasThrown.fromMaybe(false) || !result) {
if (!result) -> failure

https://codereview.chromium.org/2196003002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/js_protocol.json (right):

https://codereview.chromium.org/2196003002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/js_protocol.json:191: { "name":
"awaitPromise", "type": "boolean", "optional":true, "hidden": true,
"description": "Whether execution should wait for promise to be resolved." }
If the result of evaluation is not a Promise, it's considered to be an error.

[kozy, 2016-07-30 01:49:30]

all done. please take a look!

https://codereview.chromium.org/2196003002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp
(right):

https://codereview.chromium.org/2196003002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp:253:
scope.injectedScript()->wrapEvaluateResult(errorString,
On 2016/07/30 01:42:55, dgozman wrote:
> Check the errorString after this call.

Done.

https://codereview.chromium.org/2196003002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp:263: if
(!awaitPromise.fromMaybe(false) || wasThrown.fromMaybe(false) || !result) {
On 2016/07/30 01:42:55, dgozman wrote:
> if (!result) -> failure

result can not be null if errorString is empty.

https://codereview.chromium.org/2196003002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/js_protocol.json (right):

https://codereview.chromium.org/2196003002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/js_protocol.json:191: { "name":
"awaitPromise", "type": "boolean", "optional":true, "hidden": true,
"description": "Whether execution should wait for promise to be resolved." }
On 2016/07/30 01:42:55, dgozman wrote:
> If the result of evaluation is not a Promise, it's considered to be an error.

Done.

[kozy, 2016-07-30 04:48:16]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-30 04:48:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-30 05:57:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-30 05:57:40]

Dry run: This issue passed the CQ dry run.

[dgozman, 2016-07-30 15:16:09]

lgtm

[kozy, 2016-07-30 16:28:16]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2016-07-30 16:28:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-30 16:31:41]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-30 16:33:53]

Description was changed from

==========
[DevTools] Add awaitPromise flag to Runtime.evaluate

BUG=632875
R=dgozman@chromium.org
==========

to

==========
[DevTools] Add awaitPromise flag to Runtime.evaluate

BUG=632875
R=dgozman@chromium.org

Committed: https://crrev.com/a95aa0811a396f1e1cd0869161be1ad34b477b56
Cr-Commit-Position: refs/heads/master@{#408873}
==========

[commit-bot: I haz the power, 2016-07-30 16:33:54]

Patchset 3 (id:??) landed as
https://crrev.com/a95aa0811a396f1e1cd0869161be1ad34b477b56
Cr-Commit-Position: refs/heads/master@{#408873}