third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h - Issue 2196003002: [DevTools] Add awaitPromise flag to Runtime.evaluate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h

Issue 2196003002: [DevTools] Add awaitPromise flag to Runtime.evaluate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@add-promise-then

Patch Set: addressed comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-evaluate-async-expected.txt ('k') | third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h b/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h

index 91b0669fd67413341aa562858309492172ff88ec..e3165399fd23ba1a14de9f239ee9f206d799c0e4 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h

@@ -71,9 +71,8 @@ public:

const Maybe<bool>& returnByValue,

const Maybe<bool>& generatePreview,

const Maybe<bool>& userGesture,

- std::unique_ptr<protocol::Runtime::RemoteObject>* result,

- Maybe<bool>* wasThrown,

- Maybe<protocol::Runtime::ExceptionDetails>*) override;

+ const Maybe<bool>& awaitPromise,

+ std::unique_ptr<EvaluateCallback>) override;

void awaitPromise(ErrorString*,

const String16& promiseObjectId,

const Maybe<bool>& returnByValue,