[DevTools] Added Runtime.awaitPromise protocol method

[DevTools] Added Runtime.awaitPromise protocol method

Method will call callback when promise is fulfilled, rejected or collected.

BUG=632875
R=dgozman@chromium.org

Committed: https://crrev.com/6d917a5dc76f1de93239f06864352cea9d278603
Cr-Commit-Position: refs/heads/master@{#408849}

[kozy, 2016-07-27 23:01:39]

Dmitry, please take a look!

[dgozman, 2016-07-28 00:07:56]

https://codereview.chromium.org/2185233002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/inspector-protocol/inspector-protocol-test.js
(right):

https://codereview.chromium.org/2185233002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector-protocol/inspector-protocol-test.js:38:
InspectorTest.sendCommand("Runtime.evaluate", { "expression": expression,
"objectGroup": objectGroup }, callback);
Let's do sendCommandPromise

https://codereview.chromium.org/2185233002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-promise-then.html
(right):

https://codereview.chromium.org/2185233002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-promise-then.html:43:
function testPengingPromise(next)
typo: pending

https://codereview.chromium.org/2185233002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-promise-then.html:75:
setTimeout(gcPromise.bind(null, objectId), 0);
Let's try without setTimeout.

https://codereview.chromium.org/2185233002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/js_protocol.json (right):

https://codereview.chromium.org/2185233002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/js_protocol.json:208: { "name":
"resolvedValue", "$ref": "RemoteObject", "optional": true },
Let's add description telling that either on or the other is present.

[dgozman, 2016-07-28 00:08:42]

dgozman@chromium.org changed reviewers:
+ pfeldman@chromium.org

[dgozman, 2016-07-28 00:08:43]

Pavel, ptal at protocol.

[dgozman, 2016-07-28 20:16:07]

https://codereview.chromium.org/2185233002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp
(right):

https://codereview.chromium.org/2185233002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp:141:
class ProtocolPromiseHandler {
Let's move this to separate file.

https://codereview.chromium.org/2185233002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp:144:
ProtocolPromiseHandler(V8DebuggerImpl* debugger, int contextGroupId, const
String16& promiseObjectId,
std::unique_ptr<V8RuntimeAgentImpl::PromiseThenCallback> callback, bool
returnByValue, bool generatePreview)
protocol::Runtime::Backend::PromiseThenCallback

https://codereview.chromium.org/2185233002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp:271:
v8::Local<v8::External> wrappedCallback = makeExternal(m_debugger->isolate(),
handler);
wrappedHandler

[pfeldman, 2016-07-28 21:05:38]

https://codereview.chromium.org/2185233002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/js_protocol.json (right):

https://codereview.chromium.org/2185233002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/js_protocol.json:199: "name":
"promiseThen",
name: awaitPromise.

also... could we get following addition to existing commands (eval, evanOnCall,
callFuncOn):

            {
                "name": "evaluate",
                "parameters": [
                    { "name": "awaitPromise", "type": "boolean", "optional":
true, "hidden": true, "description": "Whether execution should wait for promise
to be resolved." },
                ],
                "returns": [
                    ...
                ],
                "description": "Evaluates expression on global object."
            },

[kozy, 2016-07-28 22:54:09]

ptal

https://codereview.chromium.org/2185233002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/inspector-protocol/inspector-protocol-test.js
(right):

https://codereview.chromium.org/2185233002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector-protocol/inspector-protocol-test.js:38:
InspectorTest.sendCommand("Runtime.evaluate", { "expression": expression,
"objectGroup": objectGroup }, callback);
On 2016/07/28 00:07:56, dgozman wrote:
> Let's do sendCommandPromise

Done.

https://codereview.chromium.org/2185233002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-promise-then.html
(right):

https://codereview.chromium.org/2185233002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-promise-then.html:43:
function testPengingPromise(next)
On 2016/07/28 00:07:56, dgozman wrote:
> typo: pending

Done.

https://codereview.chromium.org/2185233002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-promise-then.html:75:
setTimeout(gcPromise.bind(null, objectId), 0);
On 2016/07/28 00:07:56, dgozman wrote:
> Let's try without setTimeout.

Done.

https://codereview.chromium.org/2185233002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp
(right):

https://codereview.chromium.org/2185233002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp:141:
class ProtocolPromiseHandler {
On 2016/07/28 20:16:07, dgozman wrote:
> Let's move this to separate file.

Rewritten.

https://codereview.chromium.org/2185233002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp:144:
ProtocolPromiseHandler(V8DebuggerImpl* debugger, int contextGroupId, const
String16& promiseObjectId,
std::unique_ptr<V8RuntimeAgentImpl::PromiseThenCallback> callback, bool
returnByValue, bool generatePreview)
On 2016/07/28 20:16:07, dgozman wrote:
> protocol::Runtime::Backend::PromiseThenCallback

Rewritten.

https://codereview.chromium.org/2185233002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp:271:
v8::Local<v8::External> wrappedCallback = makeExternal(m_debugger->isolate(),
handler);
On 2016/07/28 20:16:07, dgozman wrote:
> wrappedHandler

Rewritten.

https://codereview.chromium.org/2185233002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/js_protocol.json (right):

https://codereview.chromium.org/2185233002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/js_protocol.json:199: "name":
"promiseThen",
On 2016/07/28 21:05:38, pfeldman wrote:
> name: awaitPromise.
> 
> also... could we get following addition to existing commands (eval,
evanOnCall,
> callFuncOn):
> 
>             {
>                 "name": "evaluate",
>                 "parameters": [
>                     { "name": "awaitPromise", "type": "boolean", "optional":
> true, "hidden": true, "description": "Whether execution should wait for
promise
> to be resolved." },
>                 ],
>                 "returns": [
>                     ...
>                 ],
>                 "description": "Evaluates expression on global object."
>             },

awaitPromise - done.

I'm not sure about additional flag.
Protocol client can emulate awaitEvaluate behavior with 10-lines function:
http://pastebin.com/jycgPrCF
I'll add this in separate CL.

https://codereview.chromium.org/2185233002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/js_protocol.json:208: { "name":
"resolvedValue", "$ref": "RemoteObject", "optional": true },
On 2016/07/28 00:07:56, dgozman wrote:
> Let's add description telling that either on or the other is present.

Done.

[kozy, 2016-07-28 22:55:08]

Description was changed from

==========
[DevTools] Added Runtime.promiseThen protocol method

Method will call callback when promise is fulfilled, rejected or collected.

BUG=none
R=dgozman@chromium.org
==========

to

==========
[DevTools] Added Runtime.awaitPromise protocol method

Method will call callback when promise is fulfilled, rejected or collected.

BUG=none
R=dgozman@chromium.org
==========

[kozy, 2016-07-29 21:50:26]

Dmitry, please take a look!

[kozy, 2016-07-29 22:00:31]

Description was changed from

==========
[DevTools] Added Runtime.awaitPromise protocol method

Method will call callback when promise is fulfilled, rejected or collected.

BUG=none
R=dgozman@chromium.org
==========

to

==========
[DevTools] Added Runtime.awaitPromise protocol method

Method will call callback when promise is fulfilled, rejected or collected.

BUG=632875
R=dgozman@chromium.org
==========

[dgozman, 2016-07-29 23:10:32]

lgtm

[kozy, 2016-07-29 23:21:17]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2016-07-29 23:21:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-30 02:48:51]

Description was changed from

==========
[DevTools] Added Runtime.awaitPromise protocol method

Method will call callback when promise is fulfilled, rejected or collected.

BUG=632875
R=dgozman@chromium.org
==========

to

==========
[DevTools] Added Runtime.awaitPromise protocol method

Method will call callback when promise is fulfilled, rejected or collected.

BUG=632875
R=dgozman@chromium.org
==========

[commit-bot: I haz the power, 2016-07-30 02:48:53]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-30 02:51:24]

Description was changed from

==========
[DevTools] Added Runtime.awaitPromise protocol method

Method will call callback when promise is fulfilled, rejected or collected.

BUG=632875
R=dgozman@chromium.org
==========

to

==========
[DevTools] Added Runtime.awaitPromise protocol method

Method will call callback when promise is fulfilled, rejected or collected.

BUG=632875
R=dgozman@chromium.org

Committed: https://crrev.com/6d917a5dc76f1de93239f06864352cea9d278603
Cr-Commit-Position: refs/heads/master@{#408849}
==========

[commit-bot: I haz the power, 2016-07-30 02:51:26]

Patchset 4 (id:??) landed as
https://crrev.com/6d917a5dc76f1de93239f06864352cea9d278603
Cr-Commit-Position: refs/heads/master@{#408849}