Fix task groups to always be self-consistent.

Fix task groups to always be self-consistent.

BUG=632775
TEST=TaskManagerBrowserTest.*

Committed: https://crrev.com/1c6f3ff833b80b5041d8756a27a465e1bacb7ffa
Cr-Commit-Position: refs/heads/master@{#409074}

[Avi (use Gerrit), 2016-07-29 21:09:17]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-29 21:09:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 21:53:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-29 21:53:43]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Avi (use Gerrit), 2016-07-31 22:59:00]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-31 22:59:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-31 23:29:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-31 23:29:32]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Avi (use Gerrit), 2016-08-01 18:17:17]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-01 18:17:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Avi (use Gerrit), 2016-08-01 18:56:36]

Description was changed from

==========
Change the Task Manager browsertests to explicitly check for the
self-consistency of task groups.

BUG=632775
TEST=TaskManagerBrowserTest.*
==========

to

==========
Fix task groups to always be self-consistent.

BUG=632775
TEST=TaskManagerBrowserTest.*
==========

[Avi (use Gerrit), 2016-08-01 18:56:36]

avi@chromium.org changed reviewers:
+ nick@chromium.org

[Avi (use Gerrit), 2016-08-01 19:01:53]

avi@chromium.org changed reviewers:
+ afakhry@chromium.org

[Avi (use Gerrit), 2016-08-01 19:01:54]

Ahmed, can you take a look at this too?

[Avi (use Gerrit), 2016-08-01 19:20:01]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-01 19:20:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ncarter (slow), 2016-08-01 19:52:49]

lgtm

https://codereview.chromium.org/2195873002/diff/60001/chrome/browser/task_man...
File chrome/browser/task_management/task_manager_browsertest.cc (right):

https://codereview.chromium.org/2195873002/diff/60001/chrome/browser/task_man...
chrome/browser/task_management/task_manager_browsertest.cc:89:
&TaskManagerBrowserTest::TaskManagerTableModelSanityCheck, this));
I'm surprised |this| doesn't need a base::Unretained. shrug?

[commit-bot: I haz the power, 2016-08-01 20:08:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-01 20:08:26]

Dry run: This issue passed the CQ dry run.

[Avi (use Gerrit), 2016-08-01 20:47:05]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-01 20:47:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Avi (use Gerrit), 2016-08-01 20:47:36]

https://codereview.chromium.org/2195873002/diff/60001/chrome/browser/task_man...
File chrome/browser/task_management/task_manager_browsertest.cc (right):

https://codereview.chromium.org/2195873002/diff/60001/chrome/browser/task_man...
chrome/browser/task_management/task_manager_browsertest.cc:89:
&TaskManagerBrowserTest::TaskManagerTableModelSanityCheck, this));
On 2016/08/01 19:52:49, ncarter wrote:
> I'm surprised |this| doesn't need a base::Unretained. shrug?

Hm. Vaguely surprising to me too. I can add that, no problem.

[Avi (use Gerrit), 2016-08-01 21:00:44]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-01 21:00:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[afakhry, 2016-08-01 21:08:11]

LGTM! Thanks again for this fix!
And thanks to Nick as well! :)

[Avi (use Gerrit), 2016-08-01 21:10:31]

The CQ bit was unchecked by avi@chromium.org

[Avi (use Gerrit), 2016-08-01 21:10:35]

The CQ bit was checked by avi@chromium.org

[Avi (use Gerrit), 2016-08-01 21:10:35]

The patchset sent to the CQ was uploaded after l-g-t-m from nick@chromium.org
Link to the patchset: https://codereview.chromium.org/2195873002/#ps100001
(title: "ahmed")

[commit-bot: I haz the power, 2016-08-01 21:10:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-01 22:33:52]

Description was changed from

==========
Fix task groups to always be self-consistent.

BUG=632775
TEST=TaskManagerBrowserTest.*
==========

to

==========
Fix task groups to always be self-consistent.

BUG=632775
TEST=TaskManagerBrowserTest.*
==========

[commit-bot: I haz the power, 2016-08-01 22:33:54]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-08-01 22:41:03]

Description was changed from

==========
Fix task groups to always be self-consistent.

BUG=632775
TEST=TaskManagerBrowserTest.*
==========

to

==========
Fix task groups to always be self-consistent.

BUG=632775
TEST=TaskManagerBrowserTest.*

Committed: https://crrev.com/1c6f3ff833b80b5041d8756a27a465e1bacb7ffa
Cr-Commit-Position: refs/heads/master@{#409074}
==========

[commit-bot: I haz the power, 2016-08-01 22:41:04]

Patchset 6 (id:??) landed as
https://crrev.com/1c6f3ff833b80b5041d8756a27a465e1bacb7ffa
Cr-Commit-Position: refs/heads/master@{#409074}