Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2653)

Unified Diff: chrome/browser/ui/task_manager/task_manager_table_model.cc

Issue 2195873002: Fix task groups to always be self-consistent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: ahmed Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/task_manager/legacy_task_manager_tester.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/task_manager/task_manager_table_model.cc
diff --git a/chrome/browser/ui/task_manager/task_manager_table_model.cc b/chrome/browser/ui/task_manager/task_manager_table_model.cc
index d921daa251a020ca5ad11d04971afc14ed8afd12..874569a6f2d96d1e271be460593b0347925679a1 100644
--- a/chrome/browser/ui/task_manager/task_manager_table_model.cc
+++ b/chrome/browser/ui/task_manager/task_manager_table_model.cc
@@ -562,17 +562,20 @@ int TaskManagerTableModel::CompareValues(int row1,
void TaskManagerTableModel::GetRowsGroupRange(int row_index,
int* out_start,
int* out_length) {
+ const base::ProcessId process_id =
+ observed_task_manager()->GetProcessId(tasks_[row_index]);
int i = row_index;
- for ( ; i >= 0; --i) {
- if (IsTaskFirstInGroup(i))
- break;
+ int limit = row_index + 1;
+ while (i > 0 &&
+ observed_task_manager()->GetProcessId(tasks_[i - 1]) == process_id) {
+ --i;
+ }
+ while (limit < RowCount() &&
+ observed_task_manager()->GetProcessId(tasks_[limit]) == process_id) {
+ ++limit;
}
-
- CHECK_GE(i, 0);
-
*out_start = i;
- *out_length = observed_task_manager()->GetNumberOfTasksOnSameProcess(
- tasks_[row_index]);
+ *out_length = limit - i;
}
void TaskManagerTableModel::OnTaskAdded(TaskId id) {
« no previous file with comments | « chrome/browser/task_manager/legacy_task_manager_tester.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698