Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4517)

Unified Diff: chrome/browser/task_management/task_manager_browsertest.cc

Issue 2195873002: Fix task groups to always be self-consistent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: ahmed Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/task_management/task_manager_tester.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/task_management/task_manager_browsertest.cc
diff --git a/chrome/browser/task_management/task_manager_browsertest.cc b/chrome/browser/task_management/task_manager_browsertest.cc
index 3b34761669eab8635e33dea2a535a1238608eefb..1a130ea1cd5d73e112be30a0802ff675e25b3f79 100644
--- a/chrome/browser/task_management/task_manager_browsertest.cc
+++ b/chrome/browser/task_management/task_manager_browsertest.cc
@@ -85,7 +85,9 @@ class TaskManagerBrowserTest : public ExtensionBrowserTest {
// Show the task manager. This populates the model, and helps with debugging
// (you see the task manager).
chrome::ShowTaskManager(browser());
- model_ = task_management::TaskManagerTester::Create(base::Closure());
+ model_ = task_management::TaskManagerTester::Create(
+ base::Bind(&TaskManagerBrowserTest::TaskManagerTableModelSanityCheck,
+ base::Unretained(this)));
}
void HideTaskManager() {
@@ -137,6 +139,20 @@ class TaskManagerBrowserTest : public ExtensionBrowserTest {
}
private:
+ void TaskManagerTableModelSanityCheck() {
+ // Ensure the groups are self-consistent.
+ for (int i = 0; i < model()->GetRowCount(); ++i) {
+ int start, length;
+ model()->GetRowsGroupRange(i, &start, &length);
+ for (int j = 0; j < length; ++j) {
+ int start2, length2;
+ model()->GetRowsGroupRange(start + j, &start2, &length2);
+ EXPECT_EQ(start, start2);
+ EXPECT_EQ(length, length2);
+ }
+ }
+ }
+
std::unique_ptr<task_management::TaskManagerTester> model_;
DISALLOW_COPY_AND_ASSIGN(TaskManagerBrowserTest);
};
« no previous file with comments | « no previous file | chrome/browser/task_management/task_manager_tester.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698