Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 2195343003: Support navigation within editable nodes. (Closed)

Created:
4 years, 4 months ago by David Tseng
Modified:
4 years, 4 months ago
Reviewers:
dmazzoni
CC:
aboxhall+watch_chromium.org, arv+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, extensions-reviews_chromium.org, je_julie, nektar+watch_chromium.org, oshima+watch_chromium.org, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Support navigation within editable nodes. This enables navigation using ChromeVox commands within editable (and richly editable) text using character, word, and line navigation. Object navigation skips over descendant editable nodes, but will still land on the top level node. In addition, when encountering a read only text field, treat it like a container (i.e. navigate inside of it). This enables navigation in crosh's terminal output. BUG=620526 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/58bd00b9212cd3df9d6b7838367dd36b5032b3ca Cr-Commit-Position: refs/heads/master@{#413287}

Patch Set 1 : m #

Patch Set 2 : Rebase. #

Patch Set 3 : Rebase and fix tests. #

Patch Set 4 : Fix test. #

Messages

Total messages: 31 (21 generated)
David Tseng
4 years, 4 months ago (2016-08-01 16:23:48 UTC) #4
dmazzoni
lgtm
4 years, 4 months ago (2016-08-02 16:34:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2195343003/60001
4 years, 4 months ago (2016-08-09 23:59:55 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/204754) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 4 months ago (2016-08-10 00:03:37 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2195343003/100001
4 years, 4 months ago (2016-08-19 17:40:56 UTC) #20
commit-bot: I haz the power
Exceeded global retry quota
4 years, 4 months ago (2016-08-19 18:31:09 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2195343003/100001
4 years, 4 months ago (2016-08-19 20:05:15 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2195343003/120001
4 years, 4 months ago (2016-08-19 20:49:57 UTC) #27
commit-bot: I haz the power
Committed patchset #4 (id:120001)
4 years, 4 months ago (2016-08-19 23:36:29 UTC) #29
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 23:38:48 UTC) #31
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/58bd00b9212cd3df9d6b7838367dd36b5032b3ca
Cr-Commit-Position: refs/heads/master@{#413287}

Powered by Google App Engine
This is Rietveld 408576698