Add support for rich output inside of content editables.

Add support for rich output inside of content editables.

This cl attempts to combine output from the editable* and output* modules.

In particular,
- speech and braille hook into editable for line descriptions
- additions were made to make cursor selections reflect the current page selection
for braille
- a minor change to make braille ignore separator additions when there's
  whitespace at the end of output. If not, cursor tracking breaks.

What works:
- earcons, roles, states are now read as you move by line
- other behaviors (e.g. other unit selections, all text changes) are unaffected.
- DOM selection changes moves ChromeVox range (e.g. move by word via ctrl+right, ChromeVox range moves with it)
- ChromeVox range changes moves the DOM selection (e.g. move by heading, by word, line, etc moves the DOM selection there).

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/c249a9e6b2659b03d75a7cb548bbf02592ef5e34
Cr-Commit-Position: refs/heads/master@{#414595}

[David Tseng, 2016-08-19 22:56:40]

Description was changed from

==========
Add support for rich output inside of content editables.

This cl attempts to combine output from the editable* and output* modules.

In particular,
- speech and braille hook into editable for line descriptions
- additions were made to make cursor selections reflect the current page
selection
for braille
- a minor change to make braille ignore separator additions when there's
  whitespace at the end of output. If not, cursor tracking breaks.

What works:
- earcons, roles, states are now read as you move by line
- other behaviors (e.g. other unit selections, all text changes) are unaffected.

m

BUG=
==========

to

==========
Add support for rich output inside of content editables.

This cl attempts to combine output from the editable* and output* modules.

In particular,
- speech and braille hook into editable for line descriptions
- additions were made to make cursor selections reflect the current page
selection
for braille
- a minor change to make braille ignore separator additions when there's
  whitespace at the end of output. If not, cursor tracking breaks.

What works:
- earcons, roles, states are now read as you move by line
- other behaviors (e.g. other unit selections, all text changes) are unaffected.

m

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-08-19 22:57:29]

dtseng@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[David Tseng, 2016-08-19 22:57:29]

Ready for a look. Tests pending.

[David Tseng, 2016-08-19 22:58:35]

Description was changed from

==========
Add support for rich output inside of content editables.

This cl attempts to combine output from the editable* and output* modules.

In particular,
- speech and braille hook into editable for line descriptions
- additions were made to make cursor selections reflect the current page
selection
for braille
- a minor change to make braille ignore separator additions when there's
  whitespace at the end of output. If not, cursor tracking breaks.

What works:
- earcons, roles, states are now read as you move by line
- other behaviors (e.g. other unit selections, all text changes) are unaffected.

m

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Add support for rich output inside of content editables.

This cl attempts to combine output from the editable* and output* modules.

In particular,
- speech and braille hook into editable for line descriptions
- additions were made to make cursor selections reflect the current page
selection
for braille
- a minor change to make braille ignore separator additions when there's
  whitespace at the end of output. If not, cursor tracking breaks.

What works:
- earcons, roles, states are now read as you move by line
- other behaviors (e.g. other unit selections, all text changes) are unaffected.



BUG=
==========

[David Tseng, 2016-08-19 23:02:07]

Description was changed from

==========
Add support for rich output inside of content editables.

This cl attempts to combine output from the editable* and output* modules.

In particular,
- speech and braille hook into editable for line descriptions
- additions were made to make cursor selections reflect the current page
selection
for braille
- a minor change to make braille ignore separator additions when there's
  whitespace at the end of output. If not, cursor tracking breaks.

What works:
- earcons, roles, states are now read as you move by line
- other behaviors (e.g. other unit selections, all text changes) are unaffected.



BUG=
==========

to

==========
Add support for rich output inside of content editables.

This cl attempts to combine output from the editable* and output* modules.

In particular,
- speech and braille hook into editable for line descriptions
- additions were made to make cursor selections reflect the current page
selection
for braille
- a minor change to make braille ignore separator additions when there's
  whitespace at the end of output. If not, cursor tracking breaks.

What works:
- earcons, roles, states are now read as you move by line
- other behaviors (e.g. other unit selections, all text changes) are unaffected.
- DOM selection changes moves ChromeVox range (e.g. move by word via ctrl+right,
ChromeVox range moves with it)
- ChromeVox range changes moves the DOM selection (e.g. move by heading, by
word, line, etc moves the DOM selection there).



BUG=
==========

[David Tseng, 2016-08-20 03:59:16]

Description was changed from

==========
Add support for rich output inside of content editables.

This cl attempts to combine output from the editable* and output* modules.

In particular,
- speech and braille hook into editable for line descriptions
- additions were made to make cursor selections reflect the current page
selection
for braille
- a minor change to make braille ignore separator additions when there's
  whitespace at the end of output. If not, cursor tracking breaks.

What works:
- earcons, roles, states are now read as you move by line
- other behaviors (e.g. other unit selections, all text changes) are unaffected.
- DOM selection changes moves ChromeVox range (e.g. move by word via ctrl+right,
ChromeVox range moves with it)
- ChromeVox range changes moves the DOM selection (e.g. move by heading, by
word, line, etc moves the DOM selection there).



BUG=
==========

to

==========
Add support for rich output inside of content editables.

This cl attempts to combine output from the editable* and output* modules.

In particular,
- speech and braille hook into editable for line descriptions
- additions were made to make cursor selections reflect the current page
selection
for braille
- a minor change to make braille ignore separator additions when there's
  whitespace at the end of output. If not, cursor tracking breaks.

What works:
- earcons, roles, states are now read as you move by line
- other behaviors (e.g. other unit selections, all text changes) are unaffected.
- DOM selection changes moves ChromeVox range (e.g. move by word via ctrl+right,
ChromeVox range moves with it)
- ChromeVox range changes moves the DOM selection (e.g. move by heading, by
word, line, etc moves the DOM selection there).



BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dmazzoni, 2016-08-22 19:27:49]

lgtm

https://codereview.chromium.org/2263513004/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js
(right):

https://codereview.chromium.org/2263513004/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js:1676: if
(cur.toString()[cur.length - 1] == Output.SPACE)
Do you want to test for other whitespace here? Or only space you inserted
yourself?

[David Tseng, 2016-08-22 21:11:26]

The CQ bit was checked by dtseng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-22 21:13:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 22:36:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-22 22:36:45]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[David Tseng, 2016-08-25 16:08:30]

The CQ bit was checked by dtseng@chromium.org

[David Tseng, 2016-08-25 16:08:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2263513004/#ps40001
(title: "Fix tests.")

[commit-bot: I haz the power, 2016-08-25 16:08:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 17:23:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 17:23:46]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[David Tseng, 2016-08-25 22:52:54]

The CQ bit was checked by dtseng@chromium.org

[David Tseng, 2016-08-25 22:52:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2263513004/#ps60001
(title: "Test fixes.")

[commit-bot: I haz the power, 2016-08-25 22:54:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 00:21:23]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-26 00:31:08]

Description was changed from

==========
Add support for rich output inside of content editables.

This cl attempts to combine output from the editable* and output* modules.

In particular,
- speech and braille hook into editable for line descriptions
- additions were made to make cursor selections reflect the current page
selection
for braille
- a minor change to make braille ignore separator additions when there's
  whitespace at the end of output. If not, cursor tracking breaks.

What works:
- earcons, roles, states are now read as you move by line
- other behaviors (e.g. other unit selections, all text changes) are unaffected.
- DOM selection changes moves ChromeVox range (e.g. move by word via ctrl+right,
ChromeVox range moves with it)
- ChromeVox range changes moves the DOM selection (e.g. move by heading, by
word, line, etc moves the DOM selection there).



BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Add support for rich output inside of content editables.

This cl attempts to combine output from the editable* and output* modules.

In particular,
- speech and braille hook into editable for line descriptions
- additions were made to make cursor selections reflect the current page
selection
for braille
- a minor change to make braille ignore separator additions when there's
  whitespace at the end of output. If not, cursor tracking breaks.

What works:
- earcons, roles, states are now read as you move by line
- other behaviors (e.g. other unit selections, all text changes) are unaffected.
- DOM selection changes moves ChromeVox range (e.g. move by word via ctrl+right,
ChromeVox range moves with it)
- ChromeVox range changes moves the DOM selection (e.g. move by heading, by
word, line, etc moves the DOM selection there).

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/c249a9e6b2659b03d75a7cb548bbf02592ef5e34
Cr-Commit-Position: refs/heads/master@{#414595}
==========

[commit-bot: I haz the power, 2016-08-26 00:31:09]

Patchset 4 (id:??) landed as
https://crrev.com/c249a9e6b2659b03d75a7cb548bbf02592ef5e34
Cr-Commit-Position: refs/heads/master@{#414595}

[David Tseng, 2016-09-06 20:24:02]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2312353002/ by dtseng@chromium.org.

The reason for reverting is: Selection api's on node failing in many cases..