Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2376)

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js

Issue 2195343003: Support navigation within editable nodes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix test. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js
diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js
index e684ec34d10c9e886a1c8ec1ae201ab7eaf824ae..c7bc3d2f772897c702de244ce530495c7a045836 100644
--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js
+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js
@@ -193,6 +193,12 @@ AutomationPredicate.leafOrStaticText = function(node) {
* @return {boolean}
*/
AutomationPredicate.object = function(node) {
+ // Editable nodes are within a text-like field and don't make sense when
+ // performing object navigation. Users should use line, word, or character
+ // navigation. Only navigate to the top level node.
+ if (node.parent && node.parent.state.editable)
+ return false;
+
return node.state.focusable ||
(AutomationPredicate.leafOrStaticText(node) &&
(/\S+/.test(node.name) ||
@@ -227,7 +233,10 @@ AutomationPredicate.container = function(node) {
node.role == RoleType.group ||
node.role == RoleType.listItem ||
node.role == RoleType.toolbar ||
- node.role == RoleType.window;
+ node.role == RoleType.window ||
+ // For example, crosh.
+ (node.role == RoleType.textField && node.state.readOnly) ||
+ (node.state.editable && node.parent && !node.parent.state.editable);
};
/**

Powered by Google App Engine
This is Rietveld 408576698