Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Unified Diff: media/base/video_decoder_config.cc

Issue 21953003: Added logging calls to FFmpegDemuxer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed something that got lost in the git madness Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/video_decoder_config.cc
diff --git a/media/base/video_decoder_config.cc b/media/base/video_decoder_config.cc
index da914f22fb94c0a669b326dc6f7c6f32f2cc0d61..76e37d37600bd1c2f8dc1d0897cbddea0d312204 100644
--- a/media/base/video_decoder_config.cc
+++ b/media/base/video_decoder_config.cc
@@ -139,6 +139,37 @@ VideoFrame::Format VideoDecoderConfig::format() const {
return format_;
}
+std::string VideoDecoderConfig::FormatName() const {
scherkus (not reviewing) 2013/08/02 21:53:48 fix indenting
Ty Overby 2013/08/02 23:04:27 Done.
+ std::string format_name;
scherkus (not reviewing) 2013/08/02 21:53:48 you don't need this -- instead just return string
Ty Overby 2013/08/02 23:04:27 Done.
+ switch(format()){
scherkus (not reviewing) 2013/08/02 21:53:48 since this is a VideoFrame::Format, it should be a
Ty Overby 2013/08/02 23:04:27 Done.
+ case VideoFrame::Format::INVALID:
+ format_name = "INVALID";
+ break;
+ case VideoFrame::Format::RGB32:
+ format_name = "RGB32";
+ break;
+ case VideoFrame::Format::YV12:
+ format_name = "YV12";
+ break;
+ case VideoFrame::Format::YV16:
+ format_name = "YV16";
+ break;
+ case VideoFrame::Format::EMPTY:
+ format_name = "EMPTY";
+ break;
+ case VideoFrame::Format::I420:
+ format_name = "I420";
+ break;
+ case VideoFrame::Format::YV12A:
+ format_name = "YV12A";
+ break;
+ default:
scherkus (not reviewing) 2013/08/02 21:53:48 we don't like default cases -- it's better to leav
Ty Overby 2013/08/02 23:04:27 Done.
+ format_name = "INVALID";
+ break;
+ }
+ return format_name;
+}
+
gfx::Size VideoDecoderConfig::coded_size() const {
return coded_size_;
}

Powered by Google App Engine
This is Rietveld 408576698