Added logging calls to FFmpegDemuxer.

media/base/video_decoder_config.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/base/video_decoder_config.h"
 
 #include "base/logging.h"
 #include "base/metrics/histogram.h"
 
 namespace media {
@@ skipping 121 matching lines @@
 }
 
 VideoCodecProfile VideoDecoderConfig::profile() const {
   return profile_;
 }
 
 VideoFrame::Format VideoDecoderConfig::format() const {
   return format_;
 }
 
+std::string VideoDecoderConfig::FormatName() const {

[scherkus (not reviewing), 2013/08/02 21:53:48]

fix indenting

[Ty Overby, 2013/08/02 23:04:27]

Done.

+      std::string format_name;

[scherkus (not reviewing), 2013/08/02 21:53:48]

you don't need this -- instead just return string

[Ty Overby, 2013/08/02 23:04:27]

Done.

+      switch(format()){

[scherkus (not reviewing), 2013/08/02 21:53:48]

since this is a VideoFrame::Format, it should be a helper method on VideoFrame


static std::string FormatToString(Format format)

[Ty Overby, 2013/08/02 23:04:27]

Done.

+        case VideoFrame::Format::INVALID:
+          format_name = "INVALID";
+          break;
+        case VideoFrame::Format::RGB32:
+          format_name = "RGB32";
+          break;
+        case VideoFrame::Format::YV12:
+          format_name = "YV12";
+          break;
+        case VideoFrame::Format::YV16:
+          format_name = "YV16";
+          break;
+        case VideoFrame::Format::EMPTY:
+          format_name = "EMPTY";
+          break;
+        case VideoFrame::Format::I420:
+          format_name = "I420";
+          break;
+        case VideoFrame::Format::YV12A:
+          format_name = "YV12A";
+          break;
+        default:

[scherkus (not reviewing), 2013/08/02 21:53:48]

we don't like default cases -- it's better to leave them out and let the
compiler complain anytime someone changes the enum definition

[Ty Overby, 2013/08/02 23:04:27]

Done. 

+          format_name = "INVALID";
+          break;
+      }
+      return format_name;
+}
+
 gfx::Size VideoDecoderConfig::coded_size() const {
   return coded_size_;
 }
 
 gfx::Rect VideoDecoderConfig::visible_rect() const {
   return visible_rect_;
 }
 
 gfx::Size VideoDecoderConfig::natural_size() const {
   return natural_size_;
 }
 
 const uint8* VideoDecoderConfig::extra_data() const {
   if (extra_data_.empty())
     return NULL;
   return &extra_data_[0];
 }
 
 size_t VideoDecoderConfig::extra_data_size() const {
   return extra_data_.size();
 }
 
 bool VideoDecoderConfig::is_encrypted() const {
   return is_encrypted_;
 }
 
 }  // namespace media