Added logging calls to FFmpegDemuxer.

media/base/media_log.cc

Index: media/base/media_log.cc
diff --git a/media/base/media_log.cc b/media/base/media_log.cc
index 0f2e1822847b8dd6773482e3161447da9b76a886..eade96fc4ba6f7ea87ca139ee7f0241c5e0a08ce 100644
--- a/media/base/media_log.cc
+++ b/media/base/media_log.cc
@@ -56,6 +56,8 @@ const char* MediaLog::EventTypeToString(MediaLogEvent::Type type) {
       return "BUFFERED_EXTENTS_CHANGED";
     case MediaLogEvent::MEDIA_SOURCE_ERROR:
       return "MEDIA_SOURCE_ERROR";
+    case MediaLogEvent::PROPERTY_CHANGE:
+      return "PROPERTY_CHANGE";
   }
   NOTREACHED();
   return NULL;
@@ -178,6 +180,41 @@ scoped_ptr<MediaLogEvent> MediaLog::CreateVideoSizeSetEvent(
   return event.Pass();
 }
 
+void MediaLog::SetProperty(

[scherkus (not reviewing), 2013/08/02 21:53:48]

these should be SetString/Integer/Double/Boolean as overloading method names is
frowned upon (e.g., that bug you hit where it picked the wrong type when using
const char*)

[Ty Overby, 2013/08/02 23:04:27]

Done.

+    const char* key, const std::string& value) {
+  scoped_ptr<MediaLogEvent> event(CreateEvent(MediaLogEvent::PROPERTY_CHANGE));
+  event->params.SetString(key, value);
+  AddEvent(event.Pass());
+}
+
+void MediaLog::SetProperty(
+    const char* key, int value) {
+  scoped_ptr<MediaLogEvent> event(CreateEvent(MediaLogEvent::PROPERTY_CHANGE));
+  event->params.SetInteger(key, value);
+  AddEvent(event.Pass());
+}
+
+void MediaLog::SetProperty(
+    const char* key, double value) {
+  scoped_ptr<MediaLogEvent> event(CreateEvent(MediaLogEvent::PROPERTY_CHANGE));
+  event->params.SetDouble(key, value);
+  AddEvent(event.Pass());
+}
+
+void MediaLog::SetProperty(
+    const char* key, bool value) {
+  scoped_ptr<MediaLogEvent> event(CreateEvent(MediaLogEvent::PROPERTY_CHANGE));
+  event->params.SetBoolean(key, value);
+  AddEvent(event.Pass());
+}
+
+void MediaLog::SetProperty(
+    const char* key, Value* value) {

[scherkus (not reviewing), 2013/08/02 21:53:48]

FYI you're not calling this method -- remove?

[Ty Overby, 2013/08/02 23:04:27]

Done.

+  scoped_ptr<MediaLogEvent> event(CreateEvent(MediaLogEvent::PROPERTY_CHANGE));
+  event->params.Set(key, value);
+  AddEvent(event.Pass());
+}
+
 scoped_ptr<MediaLogEvent> MediaLog::CreateBufferedExtentsChangedEvent(
     int64 start, int64 current, int64 end) {
   scoped_ptr<MediaLogEvent> event(