Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 2194913002: Ensure that we consistently check contains: paint for fixed position containment. (Closed)

Created:
4 years, 4 months ago by flackr
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Ensure that we consistently check contains: paint for fixed position containment. contains: paint; should contain fixed position descendants, however we had only updated this check in one place while we have many other places in the code which simply checked for having transform related properties. This patch attempts to unify all of these code paths to call through ComputedStyle::canContainFixedPositionObjects. TEST=fast/css/containment/paint-containment-with-fixed-position-scrolled.html, LayoutGeometryMapTest.ContainsFixedPositionTest, MapCoordinatesTest.FixedPosInTransform, MapCoordinatesTest.FixedPosInContainPaint BUG=619999 Review-Url: https://codereview.chromium.org/2173963002 Cr-Commit-Position: refs/heads/master@{#408002} (cherry picked from commit 139b50e91d0d86ad4ee31957a003dad264f38435) Committed: https://chromium.googlesource.com/chromium/src/+/155dfcd5829342d0e52865e8dbd7c501f3ddeef1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+191 lines, -36 lines) Patch
A + third_party/WebKit/LayoutTests/fast/css/containment/paint-containment-with-fixed-position-scrolled.html View 1 chunk +14 lines, -4 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css/containment/paint-containment-with-fixed-position-scrolled-expected.html View 1 chunk +22 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutGeometryMap.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutGeometryMapStep.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutView.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/MapCoordinatesTest.cpp View 1 chunk +70 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.cpp View 3 chunks +2 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/tests/LayoutGeometryMapTest.cpp View 1 chunk +33 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/web/tests/data/rgm_contains_fixed_position_test.html View 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
flackr
4 years, 4 months ago (2016-07-29 14:49:17 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
155dfcd5829342d0e52865e8dbd7c501f3ddeef1.

Powered by Google App Engine
This is Rietveld 408576698