third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp - Issue 2194913002: Ensure that we consistently check contains: paint for fixed position containment.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

Issue 2194913002: Ensure that we consistently check contains: paint for fixed position containment. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2785

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBox.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutGeometryMap.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp b/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

index d21deb7083ce948b52ed4c1c716110006c4f8910..32e21d222eea6c9c5cdf880f43cccccd1bc2a6dd 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

@@ -1003,7 +1003,7 @@ const LayoutObject* LayoutBoxModelObject::pushMappingToContainer(const LayoutBox

bool isInline = isLayoutInline();

bool isFixedPos = !isInline && style()->position() == FixedPosition;

- bool hasTransform = !isInline && hasLayer() && layer()->transform();

+ bool containsFixedPosition = canContainFixedPositionObjects();

LayoutSize adjustmentForSkippedAncestor;

if (ancestorSkipped) {

@@ -1029,8 +1029,8 @@ const LayoutObject* LayoutBoxModelObject::pushMappingToContainer(const LayoutBox

flags |= IsNonUniform;

if (isFixedPos)

flags |= IsFixedPosition;

- if (hasTransform)

- flags |= HasTransform;

+ if (containsFixedPosition)

+ flags |= ContainsFixedPosition;

if (shouldUseTransformFromContainer(container)) {

TransformationMatrix t;

getTransformFromContainer(container, containerOffset, t);

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBox.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutGeometryMap.cpp » ('j') | no next file with comments »