third_party/WebKit/Source/core/style/ComputedStyle.h - Issue 2194913002: Ensure that we consistently check contains: paint for fixed position containment.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/style/ComputedStyle.h

Issue 2194913002: Ensure that we consistently check contains: paint for fixed position containment. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2785

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/paint/PaintLayer.cpp ('k') | third_party/WebKit/Source/web/tests/LayoutGeometryMapTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/style/ComputedStyle.h

diff --git a/third_party/WebKit/Source/core/style/ComputedStyle.h b/third_party/WebKit/Source/core/style/ComputedStyle.h

index 846794602022d074be64f05839655c084cc3ca2f..09d8170f5b85ef04e3e097eabe1bb94e165ef624 100644

--- a/third_party/WebKit/Source/core/style/ComputedStyle.h

+++ b/third_party/WebKit/Source/core/style/ComputedStyle.h

@@ -479,6 +479,8 @@ public:

bool hasUniquePseudoStyle() const;

bool hasPseudoElementStyle() const;

+ // Note: canContainAbsolutePositionObjects should return true if canContainFixedPositionObjects.

+ // We currently never use this value directly, always OR'ing it with canContainFixedPositionObjects.

bool canContainAbsolutePositionObjects() const { return position() != StaticPosition; }

bool canContainFixedPositionObjects() const { return hasTransformRelatedProperty() || containsPaint();}