Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1593)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java

Issue 2194423004: Remove onLoadStopped/onLoadStarted from WebContentsDelegateAndroid (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java
index 55db785f021036a1f4cb2eccd50ed96d9df770f2..8fa58999606c11f0f3d503f4b4388a31d535845b 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java
@@ -132,20 +132,19 @@ public class OverlayPanelContent {
private boolean mIsFullscreen;
@Override
- public void onLoadStarted(boolean toDifferentDocument) {
- super.onLoadStarted(toDifferentDocument);
- mProgressObserver.onProgressBarStarted();
- }
-
- @Override
- public void onLoadStopped() {
- super.onLoadStopped();
- mProgressObserver.onProgressBarFinished();
+ public void loadingStateChanged(boolean toDifferentDocument) {
+ boolean isLoading = mContentViewCore != null
+ && mContentViewCore.getWebContents() != null
+ && mContentViewCore.getWebContents().isLoading();
+ if (isLoading) {
+ mProgressObserver.onProgressBarStarted();
+ } else {
+ mProgressObserver.onProgressBarFinished();
+ }
}
@Override
public void onLoadProgressChanged(int progress) {
- super.onLoadProgressChanged(progress);
mProgressObserver.onProgressBarUpdated(progress);
}

Powered by Google App Engine
This is Rietveld 408576698