chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroid.java - Issue 2194423004: Remove onLoadStopped/onLoadStarted from WebContentsDelegateAndroid

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroid.java

Issue 2194423004: Remove onLoadStopped/onLoadStarted from WebContentsDelegateAndroid (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/toolbar/BrandColorTest.java » ('j') | components/web_contents_delegate_android/android/java/src/org/chromium/components/web_contents_delegate_android/WebContentsDelegateAndroid.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroid.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroid.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroid.java

index 1193612b50221fd7c59ccd0312c671577d9e35f9..c99d98f24b48bb72ca3e6895a25bfef2885ab331 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroid.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroid.java

@@ -186,13 +186,13 @@ public class TabWebContentsDelegateAndroid extends WebContentsDelegateAndroid {

}

@Override

- public void onLoadStarted(boolean toDifferentDocument) {

- mTab.onLoadStarted(toDifferentDocument);

- }

- @Override

- public void onLoadStopped() {

- mTab.onLoadStopped();

+ public void loadingStateChanged(boolean toDifferentDocument) {

+ boolean isLoading = mTab.getWebContents() != null && mTab.getWebContents().isLoading();

+ if (isLoading) {

+ mTab.onLoadStarted(toDifferentDocument);

+ } else {

+ mTab.onLoadStopped();

+ }

}

@Override