Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: components/web_contents_delegate_android/android/java/src/org/chromium/components/web_contents_delegate_android/WebContentsDelegateAndroid.java

Issue 2194423004: Remove onLoadStopped/onLoadStarted from WebContentsDelegateAndroid (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/web_contents_delegate_android/android/java/src/org/chromium/components/web_contents_delegate_android/WebContentsDelegateAndroid.java
diff --git a/components/web_contents_delegate_android/android/java/src/org/chromium/components/web_contents_delegate_android/WebContentsDelegateAndroid.java b/components/web_contents_delegate_android/android/java/src/org/chromium/components/web_contents_delegate_android/WebContentsDelegateAndroid.java
index 48022a86b07a75c865ae20c70a8953621846ed0a..5897fa2dfeef5bdbc97b9b01f77f379db7399aef 100644
--- a/components/web_contents_delegate_android/android/java/src/org/chromium/components/web_contents_delegate_android/WebContentsDelegateAndroid.java
+++ b/components/web_contents_delegate_android/android/java/src/org/chromium/components/web_contents_delegate_android/WebContentsDelegateAndroid.java
@@ -54,11 +54,7 @@ public class WebContentsDelegateAndroid {
}
@CalledByNative
- public void onLoadStarted(boolean toDifferentDocument) {
- }
-
- @CalledByNative
- public void onLoadStopped() {
+ public void loadingStateChanged(boolean toDifferentDocument) {
mdjones 2016/08/03 20:27:41 Do we want to pass WebContents in here or should w
Ted C 2016/08/03 20:39:38 I was conflicted on that as well. I opted for bei
}
@CalledByNative

Powered by Google App Engine
This is Rietveld 408576698