Remove onLoadStopped/onLoadStarted from WebContentsDelegateAndroid

Remove onLoadStopped/onLoadStarted from WebContentsDelegateAndroid

This replaces it with loadingStateChanged, which matches
the C++ implementation and should "hopefully" be less
confusing going forward.

Still need to clean up the tab observer methods to hopefully
rid themselves of the concept there, but one step at a time.

BUG=

Committed: https://crrev.com/b80262ba07240ab6f7037dd1bf4ad53c56ccd9ff
Cr-Commit-Position: refs/heads/master@{#409683}

[Ted C, 2016-08-03 18:41:36]

tedchoc@chromium.org changed reviewers:
+ mdjones@chromium.org

[Ted C, 2016-08-03 18:41:36]

PTAL

[mdjones, 2016-08-03 20:27:41]

https://codereview.chromium.org/2194423004/diff/1/components/web_contents_del...
File
components/web_contents_delegate_android/android/java/src/org/chromium/components/web_contents_delegate_android/WebContentsDelegateAndroid.java
(right):

https://codereview.chromium.org/2194423004/diff/1/components/web_contents_del...
components/web_contents_delegate_android/android/java/src/org/chromium/components/web_contents_delegate_android/WebContentsDelegateAndroid.java:57:
public void loadingStateChanged(boolean toDifferentDocument) {
Do we want to pass WebContents in here or should we just assume that the
implementor has access? This is more a question of consistency rather than
necessity; all the existing cases already work.

[Ted C, 2016-08-03 20:39:38]

https://codereview.chromium.org/2194423004/diff/1/components/web_contents_del...
File
components/web_contents_delegate_android/android/java/src/org/chromium/components/web_contents_delegate_android/WebContentsDelegateAndroid.java
(right):

https://codereview.chromium.org/2194423004/diff/1/components/web_contents_del...
components/web_contents_delegate_android/android/java/src/org/chromium/components/web_contents_delegate_android/WebContentsDelegateAndroid.java:57:
public void loadingStateChanged(boolean toDifferentDocument) {
On 2016/08/03 20:27:41, mdjones wrote:
> Do we want to pass WebContents in here or should we just assume that the
> implementor has access? This is more a question of consistency rather than
> necessity; all the existing cases already work.

I was conflicted on that as well.  I opted for being consistent with the other
delegate methods that do not pass the source web contents up.  We pass it when
we create a new web contents, but the majority of other places don't pass the
source up.  I think if we do it here, we should do it everywhere, and that is
out of scope IMO.

[mdjones, 2016-08-03 21:17:24]

lgtm

[Ted C, 2016-08-03 23:48:55]

The CQ bit was checked by tedchoc@chromium.org

[commit-bot: I haz the power, 2016-08-03 23:49:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 00:33:07]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-04 00:34:45]

Description was changed from

==========
Remove onLoadStopped/onLoadStarted from WebContentsDelegateAndroid

This replaces it with loadingStateChanged, which matches
the C++ implementation and should "hopefully" be less
confusing going forward.

Still need to clean up the tab observer methods to hopefully
rid themselves of the concept there, but one step at a time.

BUG=
==========

to

==========
Remove onLoadStopped/onLoadStarted from WebContentsDelegateAndroid

This replaces it with loadingStateChanged, which matches
the C++ implementation and should "hopefully" be less
confusing going forward.

Still need to clean up the tab observer methods to hopefully
rid themselves of the concept there, but one step at a time.

BUG=

Committed: https://crrev.com/b80262ba07240ab6f7037dd1bf4ad53c56ccd9ff
Cr-Commit-Position: refs/heads/master@{#409683}
==========

[commit-bot: I haz the power, 2016-08-04 00:34:46]

Patchset 1 (id:??) landed as
https://crrev.com/b80262ba07240ab6f7037dd1bf4ad53c56ccd9ff
Cr-Commit-Position: refs/heads/master@{#409683}