Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3157)

Unified Diff: blimp/client/core/android/blimp_jni_registrar.cc

Issue 2194403003: blimp: Remove unneeded RegisterNatives() call (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@jnireg3
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | blimp/client/core/android/dummy_blimp_client_context_android.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/client/core/android/blimp_jni_registrar.cc
diff --git a/blimp/client/core/android/blimp_jni_registrar.cc b/blimp/client/core/android/blimp_jni_registrar.cc
index 9e71b79660d6d085db78150dc5363725cffef08b..d4dce1c13075fa4f87c64841193ca9c3852b88f1 100644
--- a/blimp/client/core/android/blimp_jni_registrar.cc
+++ b/blimp/client/core/android/blimp_jni_registrar.cc
@@ -21,9 +21,7 @@ base::android::RegistrationMethod kBlimpRegistrationMethods[] = {
} // namespace
// This method is declared in
-// //blimp/client/public/android/blimp_jni_registrar.h, and either this function
nyquist 2016/08/01 22:22:05 Why did you change this comment?
no sievers 2016/08/01 22:26:20 Oh that's an artefact from when I attempted to rem
-// or the one in //blimp/client/core/android/dummy_blimp_jni_registrar.cc
-// should be linked in to any binary blimp::client::RegisterBlimpJni.
+// //blimp/client/public/android/blimp_jni_registrar.h.
bool RegisterBlimpJni(JNIEnv* env) {
return base::android::RegisterNativeMethods(
env, kBlimpRegistrationMethods, arraysize(kBlimpRegistrationMethods));
« no previous file with comments | « no previous file | blimp/client/core/android/dummy_blimp_client_context_android.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698