Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Side by Side Diff: blimp/client/core/android/blimp_jni_registrar.cc

Issue 2194403003: blimp: Remove unneeded RegisterNatives() call (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@jnireg3
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | blimp/client/core/android/dummy_blimp_client_context_android.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "blimp/client/public/android/blimp_jni_registrar.h" 5 #include "blimp/client/public/android/blimp_jni_registrar.h"
6 6
7 #include "base/android/jni_registrar.h" 7 #include "base/android/jni_registrar.h"
8 #include "blimp/client/core/android/blimp_client_context_impl_android.h" 8 #include "blimp/client/core/android/blimp_client_context_impl_android.h"
9 #include "blimp/client/core/contents/android/blimp_contents_jni_registrar.h" 9 #include "blimp/client/core/contents/android/blimp_contents_jni_registrar.h"
10 10
11 namespace blimp { 11 namespace blimp {
12 namespace client { 12 namespace client {
13 namespace { 13 namespace {
14 14
15 base::android::RegistrationMethod kBlimpRegistrationMethods[] = { 15 base::android::RegistrationMethod kBlimpRegistrationMethods[] = {
16 {"BlimpClientContextImplAndroid", 16 {"BlimpClientContextImplAndroid",
17 BlimpClientContextImplAndroid::RegisterJni}, 17 BlimpClientContextImplAndroid::RegisterJni},
18 {"BlimpContentsJni", RegisterBlimpContentsJni}, 18 {"BlimpContentsJni", RegisterBlimpContentsJni},
19 }; 19 };
20 20
21 } // namespace 21 } // namespace
22 22
23 // This method is declared in 23 // This method is declared in
24 // //blimp/client/public/android/blimp_jni_registrar.h, and either this function 24 // //blimp/client/public/android/blimp_jni_registrar.h.
nyquist 2016/08/01 22:22:05 Why did you change this comment?
no sievers 2016/08/01 22:26:20 Oh that's an artefact from when I attempted to rem
25 // or the one in //blimp/client/core/android/dummy_blimp_jni_registrar.cc
26 // should be linked in to any binary blimp::client::RegisterBlimpJni.
27 bool RegisterBlimpJni(JNIEnv* env) { 25 bool RegisterBlimpJni(JNIEnv* env) {
28 return base::android::RegisterNativeMethods( 26 return base::android::RegisterNativeMethods(
29 env, kBlimpRegistrationMethods, arraysize(kBlimpRegistrationMethods)); 27 env, kBlimpRegistrationMethods, arraysize(kBlimpRegistrationMethods));
30 } 28 }
31 29
32 } // namespace client 30 } // namespace client
33 } // namespace blimp 31 } // namespace blimp
OLDNEW
« no previous file with comments | « no previous file | blimp/client/core/android/dummy_blimp_client_context_android.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698