Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2194403003: blimp: Remove unneeded RegisterNatives() call (Closed)

Created:
4 years, 4 months ago by no sievers
Modified:
4 years, 4 months ago
Reviewers:
nyquist
CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, gcasto+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, khushalsagar+watch-blimp_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@jnireg3
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

blimp: Remove unneeded RegisterNatives() call BUG=603936 Committed: https://crrev.com/38d2b2cbd951ca3e54365b1559cc984401631d5a Cr-Commit-Position: refs/heads/master@{#409227}

Patch Set 1 #

Total comments: 2

Patch Set 2 : blimp: Remove unneeded RegisterNatives() call #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -17 lines) Patch
M blimp/client/core/android/dummy_blimp_client_context_android.h View 1 chunk +0 lines, -1 line 0 comments Download
M blimp/client/core/android/dummy_blimp_client_context_android.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M blimp/client/core/android/dummy_blimp_jni_registrar.cc View 1 chunk +1 line, -11 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 18 (11 generated)
no sievers
dtrainor: ptal Making it so that you don't need to call RegisterNatives() anymore if there ...
4 years, 4 months ago (2016-08-01 22:14:33 UTC) #3
nyquist
https://codereview.chromium.org/2194403003/diff/1/blimp/client/core/android/blimp_jni_registrar.cc File blimp/client/core/android/blimp_jni_registrar.cc (left): https://codereview.chromium.org/2194403003/diff/1/blimp/client/core/android/blimp_jni_registrar.cc#oldcode24 blimp/client/core/android/blimp_jni_registrar.cc:24: // //blimp/client/public/android/blimp_jni_registrar.h, and either this function Why did you ...
4 years, 4 months ago (2016-08-01 22:22:05 UTC) #5
no sievers
https://codereview.chromium.org/2194403003/diff/1/blimp/client/core/android/blimp_jni_registrar.cc File blimp/client/core/android/blimp_jni_registrar.cc (left): https://codereview.chromium.org/2194403003/diff/1/blimp/client/core/android/blimp_jni_registrar.cc#oldcode24 blimp/client/core/android/blimp_jni_registrar.cc:24: // //blimp/client/public/android/blimp_jni_registrar.h, and either this function On 2016/08/01 22:22:05, ...
4 years, 4 months ago (2016-08-01 22:26:21 UTC) #7
nyquist
lgtm
4 years, 4 months ago (2016-08-01 22:28:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2194403003/20001
4 years, 4 months ago (2016-08-02 17:41:00 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-02 17:45:33 UTC) #16
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 17:48:46 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/38d2b2cbd951ca3e54365b1559cc984401631d5a
Cr-Commit-Position: refs/heads/master@{#409227}

Powered by Google App Engine
This is Rietveld 408576698