Move Range objects new owner after moving tree rather than during moving tree

Move Range objects new owner after moving tree rather than during moving tree

This patch changes moving |Range| objects to new document after moving all nodes
in tree rather than moving nodes to process |Range| in stable state, e.g.
both boundary points moved into new document by moving call of
|updateRangesAfterNodeMovedToAnotherDocument()| at end of moving tree and
renames it to |didMoveTreeToNewDocument()| to denote when it called.

BUG=633340
TEST=run_webkit_unit_tests --gtest_filter=RangeTest.updateOwnerDocumentIfNeeded

Committed: https://crrev.com/cf85ced047617936b910470b6ee8cfc490892cc7
Cr-Commit-Position: refs/heads/master@{#409446}

[yosin_UTC9, 2016-08-02 04:07:28]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 04:07:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2016-08-02 04:08:00]

Description was changed from

==========
2016-08-02T13:05:36

BUG=
==========

to

==========
2016-08-02T13:05:36

BUG=633340
==========

[commit-bot: I haz the power, 2016-08-02 04:56:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-02 04:56:35]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yosin_UTC9, 2016-08-02 07:17:26]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 07:17:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2016-08-02 08:05:06]

Description was changed from

==========
2016-08-02T13:05:36

BUG=633340
==========

to

==========
Introduce Document::didMoveTreeToNewScope()

This patch introduces |Document::didMoveTreeToNewScope()| as replacement of
|updateRangesAfterNodeMovedToAnotherDocument()| to move |Range| objects to
new document after all nodes in tree moved to new document.

Before this patch, we call |updateRangesAfterNodeMovedToAnotherDocument()| for
each node in tree and we fail to move |Range| to new document since one of
boundary point of node in |Range| isn't moved yet.

BUG=633340
TEST=run_webkit_unit_tests --gtest_filter=RangeTest.updateOwnerDocumentIfNeeded
==========

[commit-bot: I haz the power, 2016-08-02 08:30:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-02 08:30:45]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[yosin_UTC9, 2016-08-02 08:30:47]

Description was changed from

==========
Introduce Document::didMoveTreeToNewScope()

This patch introduces |Document::didMoveTreeToNewScope()| as replacement of
|updateRangesAfterNodeMovedToAnotherDocument()| to move |Range| objects to
new document after all nodes in tree moved to new document.

Before this patch, we call |updateRangesAfterNodeMovedToAnotherDocument()| for
each node in tree and we fail to move |Range| to new document since one of
boundary point of node in |Range| isn't moved yet.

BUG=633340
TEST=run_webkit_unit_tests --gtest_filter=RangeTest.updateOwnerDocumentIfNeeded
==========

to

==========
Introduce Document::didMoveTreeToNewScope()

This patch introduces |Document::didMoveTreeToNewScope()| as replacement of
|updateRangesAfterNodeMovedToAnotherDocument()| to move |Range| objects to
new document after all nodes in tree moved to new document.

Before this patch, we call |updateRangesAfterNodeMovedToAnotherDocument()| for
each node in tree and we fail to move |Range| to new document since one of
boundary point of node in |Range| isn't moved yet.

BUG=633340
TEST=run_webkit_unit_tests --gtest_filter=RangeTest.updateOwnerDocumentIfNeeded


# Failed tests
fast/dom/move-detached-child-in-range.html
fast/dom/Range/range-extract-contents-after-move-to-another-document-crash.html
==========

[yosin_UTC9, 2016-08-02 09:16:06]

Description was changed from

==========
Introduce Document::didMoveTreeToNewScope()

This patch introduces |Document::didMoveTreeToNewScope()| as replacement of
|updateRangesAfterNodeMovedToAnotherDocument()| to move |Range| objects to
new document after all nodes in tree moved to new document.

Before this patch, we call |updateRangesAfterNodeMovedToAnotherDocument()| for
each node in tree and we fail to move |Range| to new document since one of
boundary point of node in |Range| isn't moved yet.

BUG=633340
TEST=run_webkit_unit_tests --gtest_filter=RangeTest.updateOwnerDocumentIfNeeded


# Failed tests
fast/dom/move-detached-child-in-range.html
fast/dom/Range/range-extract-contents-after-move-to-another-document-crash.html
==========

to

==========
Introduce Document::didMoveTreeToNewDocument()

This patch introduces |Document::didMoveTreeToNewDocument()| as replacement of
|updateRangesAfterNodeMovedToAnotherDocument()| to move |Range| objects to
new document after all nodes in tree moved to new document.

Before this patch, we call |updateRangesAfterNodeMovedToAnotherDocument()| for
each node in tree and we fail to move |Range| to new document since one of
boundary point of node in |Range| isn't moved yet.

BUG=633340
TEST=run_webkit_unit_tests --gtest_filter=RangeTest.updateOwnerDocumentIfNeeded


# Failed tests
fast/dom/move-detached-child-in-range.html
fast/dom/Range/range-extract-contents-after-move-to-another-document-crash.html
==========

[yosin_UTC9, 2016-08-02 09:37:24]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 09:37:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 10:52:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-02 10:52:04]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2016-08-03 01:26:40]

Description was changed from

==========
Introduce Document::didMoveTreeToNewDocument()

This patch introduces |Document::didMoveTreeToNewDocument()| as replacement of
|updateRangesAfterNodeMovedToAnotherDocument()| to move |Range| objects to
new document after all nodes in tree moved to new document.

Before this patch, we call |updateRangesAfterNodeMovedToAnotherDocument()| for
each node in tree and we fail to move |Range| to new document since one of
boundary point of node in |Range| isn't moved yet.

BUG=633340
TEST=run_webkit_unit_tests --gtest_filter=RangeTest.updateOwnerDocumentIfNeeded


# Failed tests
fast/dom/move-detached-child-in-range.html
fast/dom/Range/range-extract-contents-after-move-to-another-document-crash.html
==========

to

==========
Introduce Document::didMoveTreeToNewDocument()

This patch introduces |Document::didMoveTreeToNewDocument()| as replacement of
|updateRangesAfterNodeMovedToAnotherDocument()| to move |Range| objects to
new document after all nodes in tree moved to new document.

Before this patch, we call |updateRangesAfterNodeMovedToAnotherDocument()| for
each node in tree and we fail to move |Range| to new document since the anchor
node of one of boundary points in |Range| isn't moved yet.

BUG=633340
TEST=run_webkit_unit_tests --gtest_filter=RangeTest.updateOwnerDocumentIfNeeded


# Failed tests
fast/dom/move-detached-child-in-range.html
fast/dom/Range/range-extract-contents-after-move-to-another-document-crash.html
==========

[yosin_UTC9, 2016-08-03 01:26:40]

yosin@chromium.org changed reviewers:
+ tkent@chromium.org

[yosin_UTC9, 2016-08-03 01:26:48]

PTAL

[tkent, 2016-08-03 01:42:41]

The CL description is confusing.

The CL moves the callsite of updateRangesAfterNodeMovedToAnotherDocument(), and
renames it.  Not adding didMoveTreeToNewDocument().

> # Failed tests
> fast/dom/move-detached-child-in-range.html
>
fast/dom/Range/range-extract-contents-after-move-to-another-document-crash.html

What do you mean by this?

[yosin_UTC9, 2016-08-03 02:15:21]

Description was changed from

==========
Introduce Document::didMoveTreeToNewDocument()

This patch introduces |Document::didMoveTreeToNewDocument()| as replacement of
|updateRangesAfterNodeMovedToAnotherDocument()| to move |Range| objects to
new document after all nodes in tree moved to new document.

Before this patch, we call |updateRangesAfterNodeMovedToAnotherDocument()| for
each node in tree and we fail to move |Range| to new document since the anchor
node of one of boundary points in |Range| isn't moved yet.

BUG=633340
TEST=run_webkit_unit_tests --gtest_filter=RangeTest.updateOwnerDocumentIfNeeded


# Failed tests
fast/dom/move-detached-child-in-range.html
fast/dom/Range/range-extract-contents-after-move-to-another-document-crash.html
==========

to

==========
Move Range objects new owner after moving tree rather than during moving tree

This patch changes moving |Range| objects to new document after moving all nodes
in tree rather than moving nodes to process |Range| in stable state, e.g.
both boundary points moved into new document by moving call of
|updateRangesAfterNodeMovedToAnotherDocument()| at end of moving tree and
renames it to |didMoveTreeToNewDocument()| to denote when it called.

BUG=633340
TEST=run_webkit_unit_tests --gtest_filter=RangeTest.updateOwnerDocumentIfNeeded
==========

[yosin_UTC9, 2016-08-03 02:16:31]

PTAL

On 2016/08/03 at 01:42:41, tkent wrote:
> The CL description is confusing.
> 
> The CL moves the callsite of updateRangesAfterNodeMovedToAnotherDocument(),
and renames it.  Not adding didMoveTreeToNewDocument().
I updated description.


> 
> > # Failed tests
> > fast/dom/move-detached-child-in-range.html
> >
fast/dom/Range/range-extract-contents-after-move-to-another-document-crash.html
> 
> What do you mean by this?
Oops, I forgot to remove it. It is my notes about test failures in PS#1.

[tkent, 2016-08-03 02:24:54]

lgtm

[yosin_UTC9, 2016-08-03 03:49:21]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2016-08-03 03:49:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 03:53:15]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-03 03:55:57]

Description was changed from

==========
Move Range objects new owner after moving tree rather than during moving tree

This patch changes moving |Range| objects to new document after moving all nodes
in tree rather than moving nodes to process |Range| in stable state, e.g.
both boundary points moved into new document by moving call of
|updateRangesAfterNodeMovedToAnotherDocument()| at end of moving tree and
renames it to |didMoveTreeToNewDocument()| to denote when it called.

BUG=633340
TEST=run_webkit_unit_tests --gtest_filter=RangeTest.updateOwnerDocumentIfNeeded
==========

to

==========
Move Range objects new owner after moving tree rather than during moving tree

This patch changes moving |Range| objects to new document after moving all nodes
in tree rather than moving nodes to process |Range| in stable state, e.g.
both boundary points moved into new document by moving call of
|updateRangesAfterNodeMovedToAnotherDocument()| at end of moving tree and
renames it to |didMoveTreeToNewDocument()| to denote when it called.

BUG=633340
TEST=run_webkit_unit_tests --gtest_filter=RangeTest.updateOwnerDocumentIfNeeded

Committed: https://crrev.com/cf85ced047617936b910470b6ee8cfc490892cc7
Cr-Commit-Position: refs/heads/master@{#409446}
==========

[commit-bot: I haz the power, 2016-08-03 03:55:59]

Patchset 3 (id:??) landed as
https://crrev.com/cf85ced047617936b910470b6ee8cfc490892cc7
Cr-Commit-Position: refs/heads/master@{#409446}