Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(983)

Side by Side Diff: third_party/WebKit/Source/core/dom/RangeTest.cpp

Issue 2194393004: Move Range objects new owner after moving tree rather than during moving tree (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: 2016-08-02T18:35:29 Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/dom/Range.h" 5 #include "core/dom/Range.h"
6 6
7 #include "bindings/core/v8/ExceptionStatePlaceholder.h" 7 #include "bindings/core/v8/ExceptionStatePlaceholder.h"
8 #include "core/dom/Element.h" 8 #include "core/dom/Element.h"
9 #include "core/dom/NodeList.h" 9 #include "core/dom/NodeList.h"
10 #include "core/dom/Text.h" 10 #include "core/dom/Text.h"
(...skipping 120 matching lines...) Expand 10 before | Expand all | Expand 10 after
131 EXPECT_EQ(innerRight, rangeInnerRight->endContainer()); 131 EXPECT_EQ(innerRight, rangeInnerRight->endContainer());
132 EXPECT_EQ(1, rangeInnerRight->endOffset()); 132 EXPECT_EQ(1, rangeInnerRight->endOffset());
133 133
134 EXPECT_TRUE(rangeFromTextToMiddleOfElement->boundaryPointsValid()); 134 EXPECT_TRUE(rangeFromTextToMiddleOfElement->boundaryPointsValid());
135 EXPECT_EQ(newText, rangeFromTextToMiddleOfElement->startContainer()); 135 EXPECT_EQ(newText, rangeFromTextToMiddleOfElement->startContainer());
136 EXPECT_EQ(3, rangeFromTextToMiddleOfElement->startOffset()); 136 EXPECT_EQ(3, rangeFromTextToMiddleOfElement->startOffset());
137 EXPECT_EQ(outer, rangeFromTextToMiddleOfElement->endContainer()); 137 EXPECT_EQ(outer, rangeFromTextToMiddleOfElement->endContainer());
138 EXPECT_EQ(4, rangeFromTextToMiddleOfElement->endOffset()); 138 EXPECT_EQ(4, rangeFromTextToMiddleOfElement->endOffset());
139 } 139 }
140 140
141 TEST_F(RangeTest, updateOwnerDocumentIfNeeded)
142 {
143 Element* foo = document().createElement("foo", ASSERT_NO_EXCEPTION);
144 Element* bar = document().createElement("bar", ASSERT_NO_EXCEPTION);
145 foo->appendChild(bar);
146
147 Range* range = Range::create(document(), Position(bar, 0), Position(foo, 1)) ;
148
149 Document* anotherDocument = Document::create();
150 anotherDocument->appendChild(foo);
151
152 EXPECT_EQ(bar, range->startContainer());
153 EXPECT_EQ(0, range->startOffset());
154 EXPECT_EQ(foo, range->endContainer());
155 EXPECT_EQ(1, range->endOffset());
156 }
157
141 } // namespace blink 158 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/dom/Node.cpp ('k') | third_party/WebKit/Source/core/dom/TreeScopeAdopter.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698