Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Side by Side Diff: third_party/WebKit/Source/core/dom/Document.cpp

Issue 2194393004: Move Range objects new owner after moving tree rather than during moving tree (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: 2016-08-02T18:35:29 Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org) 5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved.
7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved. 8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved.
(...skipping 3754 matching lines...) Expand 10 before | Expand all | Expand 10 after
3765 { 3765 {
3766 HeapHashSet<WeakMember<NodeIterator>> nodeIteratorsList = m_nodeIterators; 3766 HeapHashSet<WeakMember<NodeIterator>> nodeIteratorsList = m_nodeIterators;
3767 for (NodeIterator* ni : nodeIteratorsList) { 3767 for (NodeIterator* ni : nodeIteratorsList) {
3768 if (ni->root() == node) { 3768 if (ni->root() == node) {
3769 detachNodeIterator(ni); 3769 detachNodeIterator(ni);
3770 newDocument.attachNodeIterator(ni); 3770 newDocument.attachNodeIterator(ni);
3771 } 3771 }
3772 } 3772 }
3773 } 3773 }
3774 3774
3775 void Document::updateRangesAfterNodeMovedToAnotherDocument(const Node& node) 3775 void Document::didMoveTreeToNewDocument(const Node& root)
3776 { 3776 {
3777 DCHECK_NE(node.document(), this); 3777 DCHECK_NE(root.document(), this);
3778 if (m_ranges.isEmpty()) 3778 if (m_ranges.isEmpty())
3779 return; 3779 return;
3780 3780
3781 AttachedRangeSet ranges = m_ranges; 3781 AttachedRangeSet ranges = m_ranges;
3782 for (Range* range : ranges) 3782 for (Range* range : ranges)
3783 range->updateOwnerDocumentIfNeeded(); 3783 range->updateOwnerDocumentIfNeeded();
3784 } 3784 }
3785 3785
3786 void Document::nodeChildrenWillBeRemoved(ContainerNode& container) 3786 void Document::nodeChildrenWillBeRemoved(ContainerNode& container)
3787 { 3787 {
(...skipping 2246 matching lines...) Expand 10 before | Expand all | Expand 10 after
6034 } 6034 }
6035 6035
6036 void showLiveDocumentInstances() 6036 void showLiveDocumentInstances()
6037 { 6037 {
6038 WeakDocumentSet& set = liveDocumentSet(); 6038 WeakDocumentSet& set = liveDocumentSet();
6039 fprintf(stderr, "There are %u documents currently alive:\n", set.size()); 6039 fprintf(stderr, "There are %u documents currently alive:\n", set.size());
6040 for (Document* document : set) 6040 for (Document* document : set)
6041 fprintf(stderr, "- Document %p URL: %s\n", document, document->url().get String().utf8().data()); 6041 fprintf(stderr, "- Document %p URL: %s\n", document, document->url().get String().utf8().data());
6042 } 6042 }
6043 #endif 6043 #endif
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/dom/Document.h ('k') | third_party/WebKit/Source/core/dom/Node.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698