Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2194063002: [DevTools] Move canExecuteScript to V8DebuggerClient. (Closed)

Created:
4 years, 4 months ago by dgozman
Modified:
4 years, 4 months ago
Reviewers:
kozy
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kinuko+watch, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Move canExecuteScript to V8DebuggerClient. BUG=631162 Committed: https://crrev.com/8376204e18b825999bfa6b7ac3f6555590289c8e Cr-Commit-Position: refs/heads/master@{#409044}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -19 lines) Patch
M third_party/WebKit/Source/core/inspector/InspectorSession.h View 3 chunks +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorSession.cpp View 3 chunks +1 line, -9 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/MainThreadDebugger.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp View 1 chunk +6 lines, -0 lines 2 comments Download
M third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSessionClient.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Issue 2201623002 Patch 1

Messages

Total messages: 10 (3 generated)
dgozman
Could you please take a look?
4 years, 4 months ago (2016-07-31 02:45:08 UTC) #2
kozy
https://codereview.chromium.org/2194063002/diff/1/third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp File third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp (right): https://codereview.chromium.org/2194063002/diff/1/third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp#newcode267 third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp:267: LocalFrame* frame = WeakIdentifierMap<LocalFrame>::lookup(contextGroupId); Could it return nullptr?
4 years, 4 months ago (2016-08-01 18:08:04 UTC) #3
dgozman
https://codereview.chromium.org/2194063002/diff/1/third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp File third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp (right): https://codereview.chromium.org/2194063002/diff/1/third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp#newcode267 third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp:267: LocalFrame* frame = WeakIdentifierMap<LocalFrame>::lookup(contextGroupId); On 2016/08/01 18:08:03, kozyatinskiy wrote: ...
4 years, 4 months ago (2016-08-01 18:43:04 UTC) #4
kozy
lgtm
4 years, 4 months ago (2016-08-01 18:47:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2194063002/1
4 years, 4 months ago (2016-08-01 18:57:12 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-01 20:29:54 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 20:33:26 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/8376204e18b825999bfa6b7ac3f6555590289c8e
Cr-Commit-Position: refs/heads/master@{#409044}

Powered by Google App Engine
This is Rietveld 408576698