third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp - Issue 2194063002: [DevTools] Move canExecuteScript to V8DebuggerClient.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp

Issue 2194063002: [DevTools] Move canExecuteScript to V8DebuggerClient. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp ('K') | « third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp

index 0b89e7bf3b385792cc08dd229ae1b1903d8affd4..a8a677b36a4423c0038c223d52ccf77c836266eb 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp

@@ -152,7 +152,7 @@ void V8DebuggerAgentImpl::enable(ErrorString* errorString)

if (enabled())

return;

- if (!m_session->client()->canExecuteScripts()) {

+ if (!m_debugger->client()->canExecuteScripts(m_session->contextGroupId())) {

*errorString = "Script execution is prohibited";

return;

}

@@ -200,7 +200,7 @@ void V8DebuggerAgentImpl::restore()

DCHECK(!m_enabled);

if (!m_state->booleanProperty(DebuggerAgentState::debuggerEnabled, false))

return;

- if (!m_session->client()->canExecuteScripts())

+ if (!m_debugger->client()->canExecuteScripts(m_session->contextGroupId()))

return;

enable();