Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 2201623002: [DevTools] Move WorkerInspectorController to WorkerThread. (Closed)

Created:
4 years, 4 months ago by dgozman
Modified:
4 years, 4 months ago
Reviewers:
kozy, kinuko, yhirano
CC:
chromium-reviews, kinuko+worker_chromium.org, caseq+blink_chromium.org, lushnikov+blink_chromium.org, falken, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, horo+watch_chromium.org, kinuko+watch, blink-worker-reviews_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@can-execute-scripts
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Move WorkerInspectorController to WorkerThread. This allows to unify notifications flushing with main thread inspector. It also makes possible to support multiple workers/worklets sharing the same isolate in the future. BUG=none Committed: https://crrev.com/369e46c8b42e8caf633f02f034d6ef95d1424a41 Cr-Commit-Position: refs/heads/master@{#409441}

Patch Set 1 #

Patch Set 2 : rebased #

Messages

Total messages: 21 (9 generated)
dgozman
Could you please take a look?
4 years, 4 months ago (2016-07-31 04:53:23 UTC) #2
dgozman
[+kinuko] Friendly ping.
4 years, 4 months ago (2016-08-02 01:00:15 UTC) #4
kozy
lgtm
4 years, 4 months ago (2016-08-02 01:40:41 UTC) #5
yhirano
lgtm
4 years, 4 months ago (2016-08-02 02:15:00 UTC) #6
kinuko
lgtm
4 years, 4 months ago (2016-08-02 02:19:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2201623002/1
4 years, 4 months ago (2016-08-02 16:17:55 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/243972)
4 years, 4 months ago (2016-08-02 16:20:43 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2201623002/20001
4 years, 4 months ago (2016-08-02 18:43:34 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/272996)
4 years, 4 months ago (2016-08-02 21:14:22 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2201623002/20001
4 years, 4 months ago (2016-08-03 00:55:26 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-03 03:10:36 UTC) #19
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 03:11:56 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/369e46c8b42e8caf633f02f034d6ef95d1424a41
Cr-Commit-Position: refs/heads/master@{#409441}

Powered by Google App Engine
This is Rietveld 408576698