chrome://crashes: support showing the product name per crash

chrome://crashes: support showing the product name per crash

The upload list supports a new "local_id" field.  Currently we aren't
using it in the crash list, but let's start doing so.  When you have
a system crash reporter, it can be used to provide more fine grained
information as to where the crash came from (e.g. Chrome, powerd,
update engine, etc...).  When you don't (like on Linux/Windows/etc.),
it'll just say "Chrome" by default.

BUG=chromium:210624
TEST=loaded on a new system, went to chrome://crashes, and looked at listing

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262525

[xiyuan, 2014-04-02 16:26:48]

lgtm

https://codereview.chromium.org/219383008/diff/1/chrome/browser/resources/cra...
File chrome/browser/resources/crashes.js (right):

https://codereview.chromium.org/219383008/diff/1/chrome/browser/resources/cra...
chrome/browser/resources/crashes.js:41: crash['local_id'] = 'Chrome';
nit: Should we use IDS_SHORT_PRODUCT_NAME instead of hard coding?

[vapier, 2014-04-02 16:36:41]

https://codereview.chromium.org/219383008/diff/1/chrome/browser/resources/cra...
File chrome/browser/resources/crashes.js (right):

https://codereview.chromium.org/219383008/diff/1/chrome/browser/resources/cra...
chrome/browser/resources/crashes.js:41: crash['local_id'] = 'Chrome';
hmm, good idea.  lemme see how i would plumb that in.

[xiyuan, 2014-04-02 17:04:27]

https://codereview.chromium.org/219383008/diff/1/chrome/browser/resources/cra...
File chrome/browser/resources/crashes.js (right):

https://codereview.chromium.org/219383008/diff/1/chrome/browser/resources/cra...
chrome/browser/resources/crashes.js:41: crash['local_id'] = 'Chrome';
On 2014/04/02 16:36:41, vapier wrote:
> hmm, good idea.  lemme see how i would plumb that in.

Usually, we export the string from C++ side then use it via
loadTimeData.getString().

In CreateCrashesUIHTMLSource, we can export it, e.g.
  source->AddLocalizedString("shortProductName",
                             IDS_SHORT_PRODUCT_NAME).
then in JS, we can get it
  loadTimeData.getString('shortProductName');

[vapier, 2014-04-02 18:37:31]

thanks ... i've implemented that now.  and it works 'cause my page now shows
(Chromium) instead of (Chrome) :)

[vapier, 2014-04-07 19:19:14]

not sure if you wanted to double check my i10n plumbing, or if the previous LGTM
was sufficient ...

[xiyuan, 2014-04-08 17:02:06]

SLGTM in case you are waiting for me. :p

[vapier, 2014-04-08 17:37:44]

The CQ bit was checked by vapier@chromium.org

[commit-bot: I haz the power, 2014-04-08 17:37:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vapier@chromium.org/219383008/20001

[commit-bot: I haz the power, 2014-04-08 22:36:32]

Change committed as 262525