Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3486)

Unified Diff: chrome/browser/resources/crashes.js

Issue 219383008: chrome://crashes: support showing the product name per crash (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: use localized product id Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/ui/webui/crashes_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/crashes.js
diff --git a/chrome/browser/resources/crashes.js b/chrome/browser/resources/crashes.js
index 83388f8a5ff88cae64149d81a5f12dde5d712ba8..e385dd57e9bfa28d0150405775a0624cb0d27583 100644
--- a/chrome/browser/resources/crashes.js
+++ b/chrome/browser/resources/crashes.js
@@ -35,13 +35,18 @@ function updateCrashList(enabled, dynamicBackend, crashes, version) {
// Clear any previous list.
crashSection.textContent = '';
+ var productName = loadTimeData.getString('shortProductName');
+
for (var i = 0; i < crashes.length; i++) {
var crash = crashes[i];
+ if (crash['local_id'] == '')
+ crash['local_id'] = productName;
var crashBlock = document.createElement('div');
var title = document.createElement('h3');
title.textContent = loadTimeData.getStringF('crashHeaderFormat',
- crash['id']);
+ crash['id'],
+ crash['local_id']);
crashBlock.appendChild(title);
var date = document.createElement('p');
date.textContent = loadTimeData.getStringF('crashTimeFormat',
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/ui/webui/crashes_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698