Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2193223002:
Hide (mostly) unused SkColorSpace writeToICC() function (Closed)
DescriptionHide (mostly) unused SkColorSpace writeToICC() function
This originally was intended to be used for serialization, but
we've chosen another approach.
Includes a revert of:
https://codereview.chromium.org/2012133003/
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2193223002
Committed: https://skia.googlesource.com/skia/+/c213f0df22430dce53a49416c748a08715b62d9c
Patch Set 1 #
Total comments: 1
Patch Set 2 : Mark test as disabled #Patch Set 3 : Rebase #Patch Set 4 : Continue testing #
Depends on Patchset: Messages
Total messages: 27 (19 generated)
Description was changed from ========== Hide (mostly) unused writeToICC() function This originally was intended to be used for serialization, but we've chosen another approach. BUG=skia: ========== to ========== Hide (mostly) unused writeToICC() function This originally was intended to be used for serialization, but we've chosen another approach. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2193223002 ==========
Description was changed from ========== Hide (mostly) unused writeToICC() function This originally was intended to be used for serialization, but we've chosen another approach. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2193223002 ========== to ========== Hide (mostly) unused writeToICC() function This originally was intended to be used for serialization, but we've chosen another approach. Includes a revert of: https://codereview.chromium.org/2012133003/ BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2193223002 ==========
Description was changed from ========== Hide (mostly) unused writeToICC() function This originally was intended to be used for serialization, but we've chosen another approach. Includes a revert of: https://codereview.chromium.org/2012133003/ BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2193223002 ========== to ========== Hide (mostly) unused SkColorSpace writeToICC() function This originally was intended to be used for serialization, but we've chosen another approach. Includes a revert of: https://codereview.chromium.org/2012133003/ BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2193223002 ==========
msarett@google.com changed reviewers: + halcanary@google.com, mtklein@google.com, reed@google.com
https://codereview.chromium.org/2193223002/diff/1/src/core/SkColorSpace_Base.h File src/core/SkColorSpace_Base.h (right): https://codereview.chromium.org/2193223002/diff/1/src/core/SkColorSpace_Base.... src/core/SkColorSpace_Base.h:168: * Hiding this function until we can determine if we need it. Known issues include: We could also just delete it... Maybe I'm a little too attached, but I do think it's a good start if we ever want to be able to write profiles.
lgtm
The CQ bit was checked by msarett@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
We should either delete or keep testing it.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/07/29 15:10:30, mtklein wrote: > We should either delete or keep testing it. Marking test as disabled rather than deleting it.
The CQ bit was checked by msarett@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build-Ubuntu-Clang-x86_64-Debug-GN-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x...) Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...) Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Mip...) Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...) Build-Ubuntu-GCC-x86_64-Release-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...) skia_presubmit-Trybot on master.client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)
On 2016/08/01 20:04:57, msarett wrote: > On 2016/07/29 15:10:30, mtklein wrote: > > We should either delete or keep testing it. > > Marking test as disabled rather than deleting it. Using a friend class to continue testing.
lgtm
The CQ bit was checked by msarett@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by msarett@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from halcanary@google.com Link to the patchset: https://codereview.chromium.org/2193223002/#ps60001 (title: "Continue testing")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Hide (mostly) unused SkColorSpace writeToICC() function This originally was intended to be used for serialization, but we've chosen another approach. Includes a revert of: https://codereview.chromium.org/2012133003/ BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2193223002 ========== to ========== Hide (mostly) unused SkColorSpace writeToICC() function This originally was intended to be used for serialization, but we've chosen another approach. Includes a revert of: https://codereview.chromium.org/2012133003/ BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2193223002 Committed: https://skia.googlesource.com/skia/+/c213f0df22430dce53a49416c748a08715b62d9c ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://skia.googlesource.com/skia/+/c213f0df22430dce53a49416c748a08715b62d9c |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
