Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: src/core/SkColorSpace_Base.h

Issue 2193223002: Hide (mostly) unused SkColorSpace writeToICC() function (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Continue testing Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/pdf/SkPDFDocument.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/core/SkColorSpace_Base.h
diff --git a/src/core/SkColorSpace_Base.h b/src/core/SkColorSpace_Base.h
index f4507732b5eaf8b623b270441e0d859bce8d75cc..3a2518db9c176e7e4ea0e68c39a005f625370f1b 100644
--- a/src/core/SkColorSpace_Base.h
+++ b/src/core/SkColorSpace_Base.h
@@ -180,13 +180,17 @@ public:
const SkColorLookUpTable* colorLUT() const { return fColorLUT.get(); }
+private:
+
/**
- * Writes this object as an ICC profile.
+ * FIXME (msarett):
+ * Hiding this function until we can determine if we need it. Known issues include:
+ * Only writes 3x3 matrices
+ * Only writes float gammas
+ * Rejected by some parsers because the "profile description" is empty
*/
sk_sp<SkData> writeToICC() const;
-private:
-
static sk_sp<SkColorSpace> NewRGB(GammaNamed gammaNamed, const SkMatrix44& toXYZD50);
SkColorSpace_Base(GammaNamed gammaNamed, const SkMatrix44& toXYZ, Named named);
@@ -200,6 +204,7 @@ private:
friend class SkColorSpace;
friend class ColorSpaceXformTest;
+ friend class ColorSpaceTest;
typedef SkColorSpace INHERITED;
};
« no previous file with comments | « no previous file | src/pdf/SkPDFDocument.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698