third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp - Issue 2193183002: Print proper debug message in case of change event timeout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp

Issue 2193183002: Print proper debug message in case of change event timeout. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed review comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/payments/PaymentRequest.cpp ('k') | third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEvent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp

diff --git a/third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp b/third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp

index 617fa7d3a5a512a3cf5bc1a5c39e652a19a32b94..f0fb4048acc27cee6a401772abc4dca0869fd18b 100644

--- a/third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp

+++ b/third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp

@@ -332,7 +332,7 @@ TEST(PaymentRequestTest, RejectShowPromiseOnUpdateDetailsFailure)

String errorMessage;

request->show(scope.getScriptState()).then(funcs.expectNoCall(), funcs.expectCall(&errorMessage));

- request->onUpdatePaymentDetailsFailure(ScriptValue::from(scope.getScriptState(), "oops"));

+ request->onUpdatePaymentDetailsFailure("oops");

v8::MicrotasksScope::PerformCheckpoint(scope.getScriptState()->isolate());

EXPECT_EQ("AbortError: oops", errorMessage);

@@ -351,7 +351,7 @@ TEST(PaymentRequestTest, RejectCompletePromiseOnUpdateDetailsFailure)

String errorMessage;

request->complete(scope.getScriptState(), Success).then(funcs.expectNoCall(), funcs.expectCall(&errorMessage));

- request->onUpdatePaymentDetailsFailure(ScriptValue::from(scope.getScriptState(), "oops"));

+ request->onUpdatePaymentDetailsFailure("oops");

v8::MicrotasksScope::PerformCheckpoint(scope.getScriptState()->isolate());

EXPECT_EQ("AbortError: oops", errorMessage);