third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEvent.cpp - Issue 2193183002: Print proper debug message in case of change event timeout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEvent.cpp

Issue 2193183002: Print proper debug message in case of change event timeout. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed review comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp ('k') | third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEventTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEvent.cpp

diff --git a/third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEvent.cpp b/third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEvent.cpp

index 02e5161e759e7c1a53441ad2df3c00ee7f7481bd..37f6a198ec723da5f12b143e979de0ca9f688aa9 100644

--- a/third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEvent.cpp

+++ b/third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEvent.cpp

@@ -10,6 +10,7 @@

#include "core/dom/ExceptionCode.h"

#include "modules/payments/PaymentUpdater.h"

#include "public/platform/WebTraceLocation.h"

+#include "wtf/text/WTFString.h"

namespace blink {

namespace {

@@ -71,7 +72,7 @@ private:

ScriptValue call(ScriptValue value) override

{

- m_updater->onUpdatePaymentDetailsFailure(value);

+ m_updater->onUpdatePaymentDetailsFailure(toCoreString(value.v8Value()->ToString(getScriptState()->context()).ToLocalChecked()));

return ScriptValue();

}

@@ -129,7 +130,7 @@ void PaymentRequestUpdateEvent::onTimerFired(Timer<PaymentRequestUpdateEvent>*)

if (!m_updater)

return;

- m_updater->onUpdatePaymentDetailsFailure(ScriptValue());

+ m_updater->onUpdatePaymentDetailsFailure("Timed out as the page didn't resolve the promise from change event");

}

DEFINE_TRACE(PaymentRequestUpdateEvent)