third_party/WebKit/Source/modules/payments/PaymentRequest.cpp - Issue 2193183002: Print proper debug message in case of change event timeout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/payments/PaymentRequest.cpp

Issue 2193183002: Print proper debug message in case of change event timeout. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed review comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/payments/PaymentRequest.h ('k') | third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/payments/PaymentRequest.cpp

diff --git a/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp b/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp

index 697077558264391a19d958fd976005c5a4c77195..119e5eac3c8bbd34a5c0f6a0df8651e2635ef661 100644

--- a/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp

+++ b/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp

@@ -456,15 +456,12 @@ void PaymentRequest::onUpdatePaymentDetails(const ScriptValue& detailsScriptValu

m_paymentProvider->UpdateWith(mojom::blink::PaymentDetails::From(details));

}

-void PaymentRequest::onUpdatePaymentDetailsFailure(const ScriptValue& error)

+void PaymentRequest::onUpdatePaymentDetailsFailure(const String& error)

{

- String message;

- error.toString(message);

if (m_showResolver)

- m_showResolver->reject(DOMException::create(AbortError, message));

+ m_showResolver->reject(DOMException::create(AbortError, error));

if (m_completeResolver)

- m_completeResolver->reject(DOMException::create(AbortError, message));

+ m_completeResolver->reject(DOMException::create(AbortError, error));

clearResolversAndCloseMojoConnection();

}